Refactor #940
closed
The Pulp tests load their configuration from a file instead of just configuring through the config module
100%
Description
A nice improvement would be to refactor the test suite to configure the test run by just modifying pulp.server.config rather than doing complicated double config loading as happens today. This is mostly necessary to make sure the tests use a different database than the developer's normal database, but there are a few other settings configured as well in test-override-pulp.conf.
I think this is probably easy to do and I was tempted to do it as part of #131, but I decided that it was a separate concern since #131 is already a large pull request in the making.
Updated by rbarlow over 9 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to rbarlow
- Sprint/Milestone set to 16
- Platform Release set to master
- Groomed set to No
- Sprint Candidate set to No
Fixing this will solve the current build issue in https://github.com/pulp/pulp_rpm/pull/682 and I believe it will not take very long to complete. Therefore I am doing it now!
Added by rbarlow over 9 years ago
Added by rbarlow over 9 years ago
Revision a90fc5e0 | View on GitHub
Create the test config in code rather than a file.
This commit sets the test config in the test setup code, rather than importing the configuration from a test file. This is easier to edit, and also does not require the pulp.devel package to distribute a data file.
Furthermore, this commit also forbids tests to call pulp.server.config.config.set() or any variants thereof. Instead, it provides a new convenience mock function that makes it easy to patch particular settings during tests without altering the settings globally as was done before.
Many tests had to be fixed as a result of these changes, but now they are not altering global settings as they were doing before.
https://pulp.plan.io/issues/940
fixes #940
Updated by rbarlow over 9 years ago
- Status changed from ASSIGNED to POST
Updated by rbarlow over 9 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|a90fc5e0ad0d972c88c68874e839cda05eaf9e2c.
Added by rbarlow over 9 years ago
Revision 39da8a91 | View on GitHub
Initialize the DB connection in the test package.
Use the test package to start the database connection, rather than relying on test superclasses to do it. This way, only one database connection will happen during the unit tests rather than one per test class.
Additionally, mock all instances of alterations to the server config during testing.
Updated by rbarlow about 9 years ago
- Platform Release changed from master to 2.8.0
Updated by dkliban@redhat.com almost 9 years ago
- Status changed from MODIFIED to 5
Updated by rbarlow almost 9 years ago
- Status changed from 5 to 6
Our tests are no longer allowed to start their own DB connections.
Updated by dkliban@redhat.com almost 9 years ago
- Status changed from 6 to CLOSED - CURRENTRELEASE
.
Create the test config in code rather than a file.
This commit sets the test config in the test setup code, rather than importing the configuration from a test file. This is easier to edit, and also does not require the pulp.devel package to distribute a data file.
Furthermore, this commit also forbids tests to call pulp.server.config.config.set() or any variants thereof. Instead, it provides a new convenience mock function that makes it easy to patch particular settings during tests without altering the settings globally as was done before.
Many tests had to be fixed as a result of these changes, but now they are not altering global settings as they were doing before.
https://pulp.plan.io/issues/940
fixes #940