Issue #9266
closedrepository 'modify' touches all the content being added one by one
Description
Bulk touch feature of the BulkQuerySet should be used to reduce number of queries that are executed in the viewset handling the Repository Modify API.
Removing the iteration of the content in the viewset will require the task to determine if any of the content to be added doesn't exist. The task needs to raise a RuntimeError with a list of pulp_href's for the content that doesn't exist.
Related issues
Updated by dkliban@redhat.com over 3 years ago
- Related to Issue #9243: 30-50% re-sync performance regression due to touch() of content and artifacts during sync added
Updated by dkliban@redhat.com over 3 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 104
Updated by dalley over 3 years ago
Additionally, this line is problematic for the same reason, one query per content unit. The same issue led to https://pulp.plan.io/issues/7483 for the RPM plugin
There was some previous discussion about this on Matrix covering some of the competing requirements: https://riot.im/app/#/room/#pulp-dev:matrix.org/$8_vHR2IhnUvnjSU5XeimYEKXov-ed9u_Us0YtMzqvPE
Updated by dalley about 3 years ago
- Priority changed from Normal to High
- Severity changed from 2. Medium to 3. High
Bumping the prio because with a lot of content in the operation, it can easily time out the whole request. We don't have any tests running at that scale but Katello is running into this issue.
Updated by lmjachky about 3 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to lmjachky
Updated by dalley about 3 years ago
- Copied to Backport #9401: Backport #9266 "repository 'modify' touches all the content being added one by one" to 3.14.z added
Updated by pulpbot about 3 years ago
- Status changed from ASSIGNED to POST
Added by Lubos Mjachky about 3 years ago
Updated by Anonymous about 3 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|4023fce7478ad946a4f74bcfe62ce4af2ee4d83e.
Updated by pulpbot about 3 years ago
Updated by pulpbot about 3 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Do bulk_touch instead of touching one by one
closes #9266