Issue #9141: pulp/pulp_installer not honoring git_url and git_revision for pulp plugins - Pulp

Actions

Send by e-mail Copy link

Issue #9141

closed

pulp/pulp_installer not honoring git_url and git_revision for pulp plugins

Added by spredzy over 3 years ago. Updated over 3 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

Category:

Installer - Moved to GitHub issues

Sprint/Milestone:

3.14.3-1

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Groomed:

Sprint Candidate:

Tags:

Sprint:

Quarter:

Description

Based on the pulp-common roles documentation, one can specify git_url and git_revision when specifying a pulp plugin.

However this is not being honored as part of the installer process.

At least two places are lacking honoring that.

Actions

Copy link

Updated by mdepaulo@redhat.com over 3 years ago

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/templates/requirements.in.j2

This is only supposed to be run for release installs, not source installs. And the git variables are for source installs (source_dir variables / pulp_source_dir variable).

We may have bug whereby if pulpcore is installed from stable, but plugins are installed from source, then it will fail.

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L124

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L290

That only affects release installs. The source installs happen at:

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L315

Actions

Copy link

Updated by mdepaulo@redhat.com over 3 years ago

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/templates/requirements.in.j2

This is only supposed to be run for release installs, not source installs. And the git variables are for source installs (source_dir variables / pulp_source_dir variable).

We may have bug whereby if pulpcore is installed from stable, but plugins are installed from source, then it will fail.

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L124