Project

Profile

Help

Issue #9141

pulp/pulp_installer not honoring git_url and git_revision for pulp plugins

Added by spredzy 2 months ago. Updated about 2 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
Installer
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Based on the pulp-common roles documentation, one can specify git_url and git_revision when specifying a pulp plugin.

However this is not being honored as part of the installer process.

At least two places are lacking honoring that.

Associated revisions

Revision 75c07a1c View on GitHub
Added by spredzy about 2 months ago

requirements.in: Properly handle git source

fixes: #9141

Revision 75c07a1c View on GitHub
Added by spredzy about 2 months ago

requirements.in: Properly handle git source

fixes: #9141

History

#1 Updated by mdepaulo@redhat.com 2 months ago

This is only supposed to be run for release installs, not source installs. And the git variables are for source installs (source_dir variables / pulp_source_dir variable).

We may have bug whereby if pulpcore is installed from stable, but plugins are installed from source, then it will fail.

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L124

That only affects release installs. The source installs happen at:

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L315

#2 Updated by mdepaulo@redhat.com 2 months ago

This is only supposed to be run for release installs, not source installs. And the git variables are for source installs (source_dir variables / pulp_source_dir variable).

We may have bug whereby if pulpcore is installed from stable, but plugins are installed from source, then it will fail.

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L124

That only affects release installs. The source installs happen at:

https://github.com/pulp/pulp_installer/blob/master/roles/pulp_common/tasks/install_pip.yml#L315

#3 Updated by pulpbot about 2 months ago

  • Status changed from NEW to POST

#4 Updated by spredzy about 2 months ago

  • Status changed from POST to MODIFIED

#5 Updated by fao89 about 2 months ago

  • Sprint/Milestone set to 3.14.3-1

#6 Updated by pulpbot about 2 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF