Project

Profile

Help

Issue #910

Pulp's use of Django is not production ready

Added by bmbouter over 6 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.7.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

As we prepare to release Pulp's Django code, it needs to be touched up so that it is production ready.

In the settings.py file that Pulp sets DEBUG and TEMPLATE_DEBUG to True. This was helpful early on while porting Django, but now that the port is stable and to be released with Pulp 2.7.0 we should set these both to False.

Once these are disabled we will also need to update the ALLOWED_HOSTS setting which is bypassed while DEBUG=True. We set that setting here.

Finally the SECRET_KEY does not need to be kept secret in production or development so the scary warning above it needs to be removed.

These changes need to be sanity checked against the different version of Django for EL6, EL7, and FC21. You can install the desired version for testing using pip.

Associated revisions

Revision ff59e52f View on GitHub
Added by dkliban@redhat.com over 6 years ago

Turned off DEBUG in django settings.py

Fixes #910

Revision ff59e52f View on GitHub
Added by dkliban@redhat.com over 6 years ago

Turned off DEBUG in django settings.py

Fixes #910

History

#1 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com

#2 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from ASSIGNED to POST

#3 Updated by cduryee over 6 years ago

  • Triaged changed from No to Yes

#4 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#5 Updated by dkliban@redhat.com over 6 years ago

  • Status changed from MODIFIED to 5

#6 Updated by amacdona@redhat.com almost 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#7 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF