Project

Profile

Help

Backport #9083

closed

Backport 9080 "Invalid relative URLs are not identified beforehand" to 3.14.z

Added by dalley almost 3 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Triaged:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 101
Quarter:


Related issues

Copied from Pulp - Issue #9080: Invalid relative URLs are not identified beforehandCLOSED - CURRENTRELEASElmjachkyActions
Actions #1

Updated by dalley almost 3 years ago

  • Copied from Issue #9080: Invalid relative URLs are not identified beforehand added
Actions #2

Updated by dalley almost 3 years ago

  • Sprint/Milestone set to 3.14.3
Actions #3

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 100 to Sprint 101
Actions #4

Updated by mdellweg over 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to mdellweg
Actions #5

Updated by pulpbot over 2 years ago

  • Status changed from ASSIGNED to POST

Added by mdellweg over 2 years ago

Revision fc8d6568 | View on GitHub

Validate absolute pathnames in remotes' URLs

Before this change, it was not possible to determine why did the synchronization fail when a user provided a seemingly valid URL. This commit also adds more relevant information to the error message.

Having set ALLOWED_EXPORT_PATHS to ["/tmp", "/home/vagrant/test"], the following error messages are shown:

$ pulp file remote create --name test --url file://error/vagrant/test/centos-7/PULP_MANIFEST
Error: {"url":["The path 'error/vagrant/test/centos-7/PULP_MANIFEST' needs to be an absolute pathname."]}

$ pulp file remote create --name test --url file:///error/vagrant/test/centos-7/PULP_MANIFEST
Error: {"url":["The path '/error/vagrant/test/centos-7/PULP_MANIFEST' does not start with any of the allowed import paths"]}

backports #9080

fixes #9083

(cherry picked from commit d8cba5abdddbe2297e4b7c72571f08c55d88bcd4)

Actions #6

Updated by mdellweg over 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #7

Updated by pulpbot over 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF