Story #9031
closedAs a user, retain_package_versions remote option uses 0 vs. Null in an intuitive way, consistent with other Pulp configuration options
0%
Description
Ticket moved to GitHub: "pulp/pulp_rpm/2282":https://github.com/pulp/pulp_rpm/issues/2282
This issue is best understood by comparing retain_package_versions
with the similar retained_versions
options from pulpcore: retained_versions
uses Integer >= 1 plus Null
value, where retain_package_versions
uses integer >= 0 and no Null
value. Most pulp options use Null
to mean "ignore the effect of this option completely". In addition "retain 0 packages of a version" = "retain all versions of the package" is inherently unintuitive. Both for consistency with the rest of pulp and the "natural language" meaning, retain_packgae_versions
should use Null
to mean "Ignore this option/keep all versions".
See the community discussion here: https://github.com/pulp/community/discussions/36
P.S.: I am also wondering if the retain_package_versions
makes sense for other plugins that host "packages", like python and Debian. In that case it might be good to move this feature to pulpcore. (As far as I can tell the implementation uses age and is not RPM specific). But I will open a separate issue for that.
Related issues
Updated by quba42 over 3 years ago
- Related to Issue #9030: As a user I want consistent naming between the remote options retained_versions and retain_package_versions added
Updated by dalley over 3 years ago
- Tracker changed from Issue to Story
- Subject changed from The retain_package_versions remote option uses 0 vs. Null in an unintuitive way to As a user, retain_package_versions remote option uses 0 vs. Null in an intuitive way, consistent with other Pulp configuration options
- % Done set to 0
- Severity deleted (
2. Medium) - Triaged deleted (
No)
Updated by pulpbot almost 3 years ago
- Description updated (diff)
- Status changed from NEW to CLOSED - DUPLICATE