Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #8744

closed

Pulp3 database migration broken with newly release click 8

Added by equipe_serveurs@exane.com almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

With the release of click 8.0.0 the 13/05, I get the following stack trace while migrating the database. Rolling back to 7.x version solves the issue.

Cmd Run: pulpcore-manager migrat

Stack Trace:

Traceback (most recent call last):
  File "/srv/pulp/app/.venv/bin/pulpcore-manager", line 8, in <module>
    sys.exit(manage())
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/manage.py", line 11, in manage
    execute_from_command_line(sys.argv)
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 357, in execute
    django.setup()
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/django/apps/registry.py", line 122, in populate
    app_config.ready()
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/apps.py", line 94, in ready
    self.import_viewsets()
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/apps.py", line 127, in import_viewsets
    from pulpcore.app.viewsets import NamedModelViewSet
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/viewsets/__init__.py", line 1, in <module>
    from .base import (  # noqa
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/viewsets/base.py", line 17, in <module>
    from pulpcore.app import tasks
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/tasks/__init__.py", line 5, in <module>
    from .importer import pulp_import  # noqa
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/app/tasks/importer.py", line 37, in <module>
    from pulpcore.tasking.tasks import enqueue_with_reservation
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/tasking/tasks.py", line 21, in <module>
    from pulpcore.tasking import connection, util
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/pulpcore/tasking/connection.py", line 1, in <module>
    from rq.cli.helpers import get_redis_from_config
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/rq/cli/__init__.py", line 2, in <module>
    from .cli import main
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/rq/cli/cli.py", line 98, in <module>
    @pass_cli_config
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/rq/cli/cli.py", line 77, in pass_cli_config
    func = option(func)
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/click/decorators.py", line 247, in decorator
    _param_memo(f, OptionClass(param_decls, **option_attrs))
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/click/core.py", line 2467, in __init__
    super().__init__(param_decls, type=type, multiple=multiple, **attrs)
  File "/srv/pulp/app/.venv/lib/python3.6/site-packages/click/core.py", line 2108, in __init__
    ) from None
ValueError: 'default' must be a list when 'multiple' is true.

Related issues

Related to Pulp - Issue #8743: Ansible playbooks fail on database migrations due to click versionCLOSED - NOTABUGActions
Actions
Copy link
 #1

Updated by daviddavis almost 3 years ago

Looks like rq doesn't work with click 8 (yet) but they have a PR open:

https://github.com/rq/rq/pull/1465

Actions
Copy link
 #2

Updated by mdellweg almost 3 years ago

pulpcore depends on click~=7.1.2 so this should prevent an upgrade of click to 8.0.0.

Actions
Copy link
 #3

Updated by daviddavis almost 3 years ago

Actions
Copy link
 #4

Updated by daviddavis almost 3 years ago

  • Related to Issue #8743: Ansible playbooks fail on database migrations due to click version added
Actions
Copy link
 #5

Updated by bmbouter almost 3 years ago

pulpcore==3.11.2 (coming soon) and 3.13.0 (also soon) will both resolve this. We don't have plans to release a fix onto 3.12.z right now because our releasing isn't automated well enough right now and we can't afford to release the backport to that z stream relative to other priorities.

Another option is to manually upgrade RQ to latest and then you can use either version of click you want.

Actions
Copy link
 #6

Updated by daviddavis almost 3 years ago

  • Status changed from NEW to CLOSED - CURRENTRELEASE

I believe this has been fixed.

Actions
Send by e-mail Copy link

Also available in: Atom PDF