Project

Profile

Help

Issue #8722

The checksum type from a remote source is not used by for a publication

Added by ttereshc about 1 month ago. Updated 3 days ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 98
Quarter:

Description

To reproduce:

Observe that metadata uses sha256 checksum type.

This affects Pulp 3 -> Pulp 2 sync (aka smart proxy use case), because Pulp 2 is looking at the metadata checksum (sha256 in our case) and uses it for everything, including content. But in case of on_demand sync only md5 is available in the reproducer example.

Associated revisions

Revision 37bdbfb7 View on GitHub
Added by dalley 3 days ago

Allow checksum types to be unspecified for publish

Intelligently decide which checksum types to use if the user left them unspecified.

closes: #8722 https://pulp.plan.io/issues/8722

History

#1 Updated by ttereshc about 1 month ago

I think the root cause of the issue is the evolution of the checksum type feature.
First, only sha256 was used and it was treated as a default for publications.
Then Pulp started accepting a one-time option at publication time to have a custom checksum type.
Then Pulp started to consider the original checksum type which comes from the remote source, and the precedence was: one-time option at publish time, original checksum type, default value.
Then the configuration of checksum type became available on the repository model, and it has a default value, which is currently has higher precedence than the original checksum type. I think it is not an intentional behaviour.

I suggest to remove a default for the repository configuration and allow it to be not configured.

#2 Updated by ipanova@redhat.com about 1 month ago

ttereshc wrote:

I think the root cause of the issue is the evolution of the checksum type feature.
First, only sha256 was used and it was treated as a default for publications.
Then Pulp started accepting a one-time option at publication time to have a custom checksum type.
Then Pulp started to consider the original checksum type which comes from the remote source, and the precedence was: one-time option at publish time, original checksum type, default value.
Then the configuration of checksum type became available on the repository model, and it has a default value, which is currently has higher precedence than the original checksum type. I think it is not an intentional behaviour.

I suggest to remove a default for the repository configuration and allow it to be not configured.

Docs also should be updated https://docs.pulpproject.org/pulp_rpm/workflows/create_sync_publish.html#create-a-publication

#5 Updated by dalley about 1 month ago

Then the configuration of checksum type became available on the repository model, and it has a default value, which is currently has higher precedence than the original checksum type. I think it is not an intentional behaviour.

Agreed.

#6 Updated by pulpbot 19 days ago

  • Status changed from NEW to POST

#7 Updated by ttereshc 7 days ago

  • Assignee set to dalley
  • Sprint set to Sprint 98

#8 Updated by dalley 4 days ago

  • Triaged changed from No to Yes

#9 Updated by dalley 3 days ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF