Project

Profile

Help

Issue #8438

closed

Allow plugins to unset attribute in NamedModelViewSet

Added by awcrosby over 1 year ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Today if a ViewSet sets the NamedModelViewSet queryset_filtering_required_permission the plugin must use the attribute as-is or replace it and must use it. Since this is an optional attribute, pulpcore should support a plugin unsetting this attribute via setting to None, which is checked here: https://github.com/pulp/pulpcore/blob/master/pulpcore/app/viewsets/base.py#L331

Actions #2

Updated by pulpbot over 1 year ago

  • Status changed from NEW to POST
Actions #3

Updated by fao89 over 1 year ago

  • Triaged changed from No to Yes

Added by Andrew Crosby over 1 year ago

Revision a23f0bf2

Allow plugins to unset attribute in NamedModelViewSet

Allow plugins to set queryset_filtering_required_permission attribute to None and have it behave the same way as if the attribute were not present.

fixes #8438 https://pulp.plan.io/issues/8438

Actions #4

Updated by Anonymous over 1 year ago

  • Status changed from POST to MODIFIED
Actions #5

Updated by mdellweg over 1 year ago

  • Sprint/Milestone set to 3.12.0
Actions #6

Updated by pulpbot over 1 year ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF