Project

Profile

Help

Issue #8051

closed

Token refresh POST request is missing proxy argument.

Added by rochacbruno almost 2 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 88
Quarter:

Description

On this line

https://github.com/pulp/pulp_ansible/blob/97e705403fb981113a79ee4c5bd592f50ef3283f/pulp_ansible/app/downloaders.py#L160

async with self.session.post(url, data=form_payload, raise_for_status=True) as response:

A POSt request is made to refresh token but the request is missing the proxy argument when it is provided on remote.

All requests must use the proxy like this https://github.com/pulp/pulp_ansible/blob/97e705403fb981113a79ee4c5bd592f50ef3283f/pulp_ansible/app/downloaders.py#L132

async with self.session.get(self.url, headers=headers, proxy=self.proxy) as response:

Galaxy Related Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1913816

and https://issues.redhat.com/browse/AAH-248

Actions #1

Updated by fao89 almost 2 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 88
Actions #2

Updated by fao89 almost 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
Actions #3

Updated by pulpbot almost 2 years ago

  • Status changed from ASSIGNED to POST

Added by Fabricio Aguiar almost 2 years ago

Revision d6a3d709

Enable proxy on token refresh requests

https://pulp.plan.io/issues/8051 closes #8051

Actions #4

Updated by Anonymous almost 2 years ago

  • Status changed from POST to MODIFIED

Added by Fabricio Aguiar almost 2 years ago

Revision 82811476

Enable proxy on token refresh requests

https://pulp.plan.io/issues/8051 closes #8051

(cherry picked from commit d6a3d709599e69425ff9cb7c9108d75341212aa8)

Actions #6

Updated by fao89 almost 2 years ago

  • Sprint/Milestone set to 0.5.6
Actions #7

Updated by pulpbot almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #8

Updated by fao89 almost 2 years ago

  • Status changed from CLOSED - CURRENTRELEASE to MODIFIED
Actions #10

Updated by fao89 almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #11

Updated by fao89 almost 2 years ago

  • Status changed from CLOSED - CURRENTRELEASE to MODIFIED

Added by Fabricio Aguiar almost 2 years ago

Revision ffa9ac2c

Enable proxy on token refresh requests

https://pulp.plan.io/issues/8051 closes #8051

(cherry picked from commit d6a3d709599e69425ff9cb7c9108d75341212aa8)

Actions #12

Updated by fao89 almost 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF