Project

Profile

Help

Actions
Send by e-mail Copy link

Task #7930

closed

Make PulpPluginAppConfig.version required

Added by bmbouter about 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
bmbouter
Category:
-
Sprint/Milestone:
3.10.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

With 3.9 we introduced warnings in PulpPluginAppConfig.__init__ encouraging plugin writers to add a version attribute to their PulpPluginAppConfig subclasses.

With 3.10 we should remove the warnings and Pulp should refuse to start if any of its plugins do not set version in this way.

Related issues

Related to Pulp - Task #8198: Make the status API and openAPI schema version listing report on django installed plugins not python packagesCLOSED - CURRENTRELEASEbmbouter

Actions
Actions
Copy link
 #1

Updated by mdellweg about 4 years ago

Additionally to the status api, the version listing in the api doc should do the same.

Actions
Copy link
 #2

Updated by bmbouter about 4 years ago

  • Subject changed from Make PulpPluginAppConfig.version required and used by the status API to Make PulpPluginAppConfig.version required and used by the status API and API schema version listing
  • Description updated (diff)

Great idea, but I'm not sure where in the code that happens. Do you know?

Actions
Copy link
 #4

Updated by bmbouter almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
Actions
Copy link
 #5

Updated by bmbouter almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by pulpbot almost 4 years ago

  • Status changed from ASSIGNED to POST

Added by bmbouter almost 4 years ago

Revision 9d5a5b5c | View on GitHub

Requires Pulp plugins to provide version

It adds enforcement that the version to be set on the PulpPluginAppConfig subclass. If an installed plugin does not specify its version Pulp will refuse to start.

closes #7930

Actions
Copy link
 #8

Updated by bmbouter almost 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by bmbouter almost 4 years ago

  • Subject changed from Make PulpPluginAppConfig.version required and used by the status API and API schema version listing to Make PulpPluginAppConfig.version required
  • Description updated (diff)

I moved the status API and openAPI schema parts to this 3.11 issue: https://pulp.plan.io/issues/8198

Actions
Copy link
 #10

Updated by bmbouter almost 4 years ago

  • Related to Task #8198: Make the status API and openAPI schema version listing report on django installed plugins not python packages added
Actions
Copy link
 #11

Updated by pulpbot almost 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF