Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #7918

closed

FilesystemExporter does not gracefully handle exporting multiple times

Added by daviddavis almost 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Ticket moved to GitHub: "pulp/pulpcore/1949":https://github.com/pulp/pulpcore/issues/1949

The move to GHA exposed this bug (not sure how it wasn't an issue in Travis but I was able to reproduce locally).

If there are pre-existing files in the location that FileSystem attempts to export to you get a FileExistsError. This is common in the case where you're exporting multiple times.

Some potential solutions:

  1. Check that the directory is empty before exporting. Maybe even refuse to export but have a --force flag that will remove files in this directory.
  2. Ignore file exists errors either silently or raise a warning.

Related issues

Related to Pulp - Task #7890: Unskip broken filesystem exporter testCLOSED - CURRENTRELEASEdaviddavis

Actions
Actions
Copy link
 #1

Updated by daviddavis almost 4 years ago

  • Related to Task #7890: Unskip broken filesystem exporter test added
Actions
Copy link
 #2

Updated by fao89 almost 4 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by ipanova@redhat.com almost 4 years ago

I would ignore file exists error. If with every export we expect an additive mode, it would be a waste to --force remove existing file so just in a later step place them back.

Actions
Copy link
 #4

Updated by pulpbot almost 3 years ago

  • Description updated (diff)
  • Status changed from NEW to CLOSED - DUPLICATE
Actions
Send by e-mail Copy link

Also available in: Atom PDF