Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #7898

closed

No-op copy operations perform a lot of unnecessary work

Added by dalley over 3 years ago. Updated about 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
dalley
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.21.5
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

If search criteria were provided but no matching content units were found, nothing can possibly be copied by Pulp, so we can exit early.

Currently, we go through the motions anyway, which is extremely demanding on the host system.

Added by dalley over 3 years ago

Revision 651ea938 | View on GitHub

Add an optimization for empty copy operations

If we know there can be nothing copied, exit early rather than doing useless work.

closes: #7898 https://pulp.plan.io/issues/7898

Actions
Copy link
 #3

Updated by dalley over 3 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #4

Updated by ipanova@redhat.com over 3 years ago

  • Platform Release set to 2.21.5
Actions
Copy link
 #5

Updated by ipanova@redhat.com over 3 years ago

  • Project changed from Pulp to RPM Support

Added by dalley over 3 years ago

Revision 5c5055b6 | View on GitHub

Add an optimization for empty copy operations

If we know there can be nothing copied, exit early rather than doing useless work.

closes: #7898 https://pulp.plan.io/issues/7898 (cherry picked from commit 651ea938d8ff5696301df34d988e6c86bccd949a)

Actions
Copy link
 #6

Updated by ggainey about 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF