Project

Profile

Help

Issue #7740

closed

Syncing requirements is not handling pagination correctly

Added by daviddavis over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Run this test and it will fail:

    def test_sync_with_aws_requirements(self):
        """Test to sync down amazon.aws versions."""
        requirements_file = "collections:\n  - amazon.aws"

        repo = self.client.post(ANSIBLE_REPO_PATH, gen_repo())
        self.addCleanup(self.client.delete, repo["pulp_href"])

        collection_remote = self.client.post(
            ANSIBLE_COLLECTION_REMOTE_PATH,
            gen_ansible_remote(
                url=ANSIBLE_GALAXY_COLLECTION_URL_V2.rstrip("/"),
                requirements_file=requirements_file,
            ),
        )

        self.addCleanup(self.client.delete, collection_remote["pulp_href"])

        sync(self.cfg, collection_remote, repo, mirror=True)
        repo = self.client.get(repo["pulp_href"])
        added_content_summary = get_added_content_summary(repo)
        self.assertGreaterEqual(
            added_content_summary[ANSIBLE_COLLECTION_CONTENT_NAME], 67
        )

        content_summary = get_content_summary(repo)
        self.assertGreaterEqual(
            content_summary[ANSIBLE_COLLECTION_CONTENT_NAME], 67
        )

Failure:

AssertionError: 10 not greater than or equal to 67

There's currently 67 collection versions for aws on galaxy:

https://galaxy.ansible.com/api/v2/collections/amazon/aws/versions/

Also available in: Atom PDF