Project

Profile

Help

Maintenance: Planio will be observing a scheduled maintenance window this Tuesday, November 5, 2024 from 03:00 UTC until 06:30 UTC to perform urgent network maintenance in our primary data center. Your Planio account will be unavailable during this maintenance window.

Issue #7414

closed

Checksum model for distribution tree allows null value for a checksum

Added by ttereshc about 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 84
Quarter:

Description

The Checksum model for distribution tree allows a null value for the checksum field.. The checksum field is a part of uniqueness constraint. Since it's allowed to be null, and every null is unique, it's possible to have duplicates.

There is a spec (somewhat outdated) https://release-engineering.github.io/productmd/treeinfo-1.0.html which seems to say that checksums should always be present.

I'm not sure about real world examples when checksum type is null for this model, however the data migration needs to consider that theoretical possibility.

Actions #1

Updated by ttereshc about 4 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 80
Actions #2

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 80 to Sprint 81
Actions #3

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 81 to Sprint 82
Actions #4

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 82 to Sprint 83
Actions #5

Updated by ppicka about 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions #6

Updated by ppicka about 4 years ago

Noticed that in case of checksum missing e.g.

[checksums]
images/pxeboot/upgrade.img = sha256:30e14955ebf1352266dc2ff8067e68104607e750abb9d3b36582b8af909fcb58
images/pxeboot/vmlinuz =

productmd.treeinfo.TreeInfo used in our parsing will count hash.

fixtures/rpm-distribution-tree/addons/dolphin/repodata/repomd.xml

entry like this fail the sync

in this case do we want manual migration when 'null' can't (shouldn't) happen, and we do not save repomd.xml file to re-count its hash?

Actions #7

Updated by pulpbot about 4 years ago

  • Status changed from ASSIGNED to POST
Actions #8

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 83 to Sprint 84

Added by ppicka about 4 years ago

Revision c56bac11 | View on GitHub

Checksum to not allow null

Removing allow_null from checksum field from checksum model.

closes: #7414 https://pulp.plan.io/issues/7414 [nocoverage]

Actions #9

Updated by ppicka about 4 years ago

  • Status changed from POST to MODIFIED
Actions #10

Updated by dalley almost 4 years ago

  • Sprint/Milestone set to 3.8.0
Actions #11

Updated by pulpbot almost 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF