Project

Profile

Help

Issue #7283

new ruby bindings send default checksum types

Added by jsherril@redhat.com over 1 year ago. Updated 6 months ago.

Status:
CLOSED - NOTABUG
Priority:
Low
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Quarter:

Description

new bindings send a default checksum type when creating a publication.

Previously the 3.4 ruby bindings when creating a publication resulted in a publication request body of:

{"repository_version":"/pulp/api/v3/repositories/rpm/rpm/03b20f89-a2a3-4a02-8ea5-9af641623d15/versions/0/"}

after updating to pulp_rpm_client (3.6.0.dev01596557138), we now get a request body of:

{"repository_version":"/pulp/api/v3/repositories/rpm/rpm/7fcae337-d94c-4422-bd35-295943f48533/versions/0/","metadata_checksum_type":"sha256","package_checksum_type":"sha256"}

This might be fine, but i wanted to make sure it was intentional.

History

#1 Updated by jsherril@redhat.com over 1 year ago

and to be clear, this is not an issue necessarily and this issue can be closed if the change is decided to be expected

#2 Updated by ttereshc over 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 80

Adding to the sprint for the investigation.

#3 Updated by rchan about 1 year ago

  • Sprint changed from Sprint 80 to Sprint 81

#4 Updated by rchan about 1 year ago

  • Sprint changed from Sprint 81 to Sprint 82

#5 Updated by ttereshc about 1 year ago

  • Sprint deleted (Sprint 82)

#6 Updated by dalley 6 months ago

I suspect this has nothing to do with the bindings at all. At least the serializers don't specify any such default.

I think what happened is that we set a default checksum types if none was specified (or try to use the original checksum types if it was recorded), but this happens inside of Pulp, not inside of the bindings.

https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/tasks/publishing.py#L250

In any case I do think it's intentional

@Justin, would you consider this a problem? Is it something you have to work around inside of Katello? (See also https://pulp.plan.io/issues/8722 which is more recent but the same kind of discussion)

#7 Updated by jsherril@redhat.com 6 months ago

  • Status changed from NEW to CLOSED - NOTABUG

sounds fine to me!

Please register to edit this issue

Also available in: Atom PDF