Project

Profile

Help

Issue #7185

force_full rsync publish is done unnecessarily in some cases

Added by yuzheng over 1 year ago. Updated about 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.21.4
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

A full rsync publish is done when some criteria are met (defined in https://github.com/pulp/pulp/blob/2-master/server/pulp/plugins/rsync/publish.py#L373). Some of the criteria don't need a full rsync publish to make the right content published to rsync distributor:

  • When there's units removal since last rsync publish
  • When there's predistributor publish failure since last rsync publish

Since it takes longer time to do full publish, especially for big repos containing lots of units, unnecessary full publish should be avoided by removing above criteria.

Associated revisions

Revision 7fff42fc View on GitHub
Added by yuzheng over 1 year ago

Remove unnecessary criteria of force_full rsync publish (#3997)

  • Remove unnecessary criteria of force_full rsync publish

Rsync publish after units removal or failed predistributor publish doesn't have to be force_full publish, so remove them from criteria.

RepoPublishResult doesn't have distributor_config, so the criteria of predistributor_force_full doesn't work, remove it.

closes #7185 https://pulp.plan.io/issues/7185

  • Remove useless variable

Revision c262d314 View on GitHub
Added by yuzheng over 1 year ago

Remove unnecessary criteria of force_full rsync publish (#3997)

  • Remove unnecessary criteria of force_full rsync publish

Rsync publish after units removal or failed predistributor publish doesn't have to be force_full publish, so remove them from criteria.

RepoPublishResult doesn't have distributor_config, so the criteria of predistributor_force_full doesn't work, remove it.

closes #7185 https://pulp.plan.io/issues/7185

  • Remove useless variable

(cherry picked from commit 7fff42fc218b94cabf8140053ef393b54a427a02)

History

#1 Updated by fao89 over 1 year ago

  • Triaged changed from No to Yes

#2 Updated by yuzheng over 1 year ago

  • Status changed from NEW to MODIFIED

#3 Updated by ggainey over 1 year ago

  • Platform Release set to 2.21.4

#4 Updated by ggainey about 1 year ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF