Project

Profile

Help

Task #7021

closed

The artifacts property on repo version doesn't return all repo version artifacts

Added by daviddavis over 2 years ago. Updated about 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 78
Quarter:

Description

The artifacts property on RepositoryVersion assumes that artifacts are all directly attached to RepositoryVersion Content:

RepositoryVersion
   |
Content
   |
Artifacts

But with DistributionTrees, this is not the case. There are also artifacts nested in repos:

RepositoryVersion
   |
DistributionTree
   |
Repository/RepositoryVersion
   |
Content
   |
Artifacts

This means that not all artifacts will get exported when the DistributionTree is exported.

Solution

Have the artifacts property method call a Repository method to determine what artifacts it has. This is needed since RepositoryVersion is not typed. Then pulp_rpm (and other plugins) can override this method to add in artifacts from DistributionTrees.

Possible Alternative(s)

Add a hook to the artifact export code that will allow plugins to define what artifacts belong to a repo version.


Related issues

Blocks RPM Support - Story #6739: As a user, I can export and import kickstart treesCLOSED - CURRENTRELEASEdaviddavis

Actions
Actions #1

Updated by daviddavis over 2 years ago

  • Description updated (diff)
Actions #2

Updated by daviddavis over 2 years ago

  • Description updated (diff)
Actions #3

Updated by daviddavis over 2 years ago

  • Description updated (diff)
Actions #4

Updated by daviddavis over 2 years ago

  • Blocks Story #6739: As a user, I can export and import kickstart trees added
Actions #5

Updated by daviddavis over 2 years ago

  • Tracker changed from Issue to Task
  • % Done set to 0
  • Severity deleted (2. Medium)
  • Triaged deleted (No)
Actions #6

Updated by daviddavis over 2 years ago

  • Sprint set to Sprint 75
Actions #7

Updated by daviddavis over 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions #8

Updated by pulpbot over 2 years ago

  • Status changed from ASSIGNED to POST
Actions #9

Updated by rchan over 2 years ago

  • Sprint changed from Sprint 75 to Sprint 76
Actions #10

Updated by rchan about 2 years ago

  • Sprint changed from Sprint 76 to Sprint 77
Actions #11

Updated by rchan about 2 years ago

  • Sprint changed from Sprint 77 to Sprint 78

Added by daviddavis about 2 years ago

Revision 4fc288ee

Allow plugins to modify logic for repo version artifacts

fixes #7021

Actions #12

Updated by daviddavis about 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #13

Updated by dkliban@redhat.com about 2 years ago

  • Sprint/Milestone set to 3.6.0
Actions #14

Updated by pulpbot about 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF