Project

Profile

Help

Issue #6303

If same content is provided by 2 remotes, resync raises ValueError: Path is duplicated

Added by ttereshc 28 days ago. Updated 7 days ago.

Status:
MODIFIED
Priority:
High
Category:
-
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 68

Description

Create 2 repos and 2 remotes:

Sync from each remote into a separate repo. Sync again any repo, observe the issue below.

I was not able to reproduce it with fixture repos: rpm-unsigned and rpm_with_modules :/

Even though nothing changed in a repo, the unsaved version shows non-null counters for added/removed_memberships. And unsaved version indeed contains duplicated paths.

The package univocity-parsers-2.5.5-5.module_f28+3873+06cd63fa.noarch.rpm is present in both remote repos.

Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]: Traceback (most recent call last):
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/usr/local/lib/pulp/lib64/python3.7/site-packages/rq/worker.py", line 884, in perform_job
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     rv = job.perform()
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/usr/local/lib/pulp/lib64/python3.7/site-packages/rq/job.py", line 664, in perform
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     self._result = self._execute()
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/usr/local/lib/pulp/lib64/python3.7/site-packages/rq/job.py", line 670, in _execute
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     return self.func(*self.args, **self.kwargs)
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulp_rpm/pulp_rpm/app/tasks/synchronizing.py", line 152, in synchronize
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     dv.create()
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulpcore/pulpcore/plugin/stages/declarative_version.py", line 149, in create
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     loop.run_until_complete(pipeline)
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulpcore/pulpcore/app/models/repository.py", line 782, in __exit__
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     repository.finalize_new_version(self)
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulp_rpm/pulp_rpm/app/models/repository.py", line 114, in finalize_new_version
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     validate_version_paths(new_version)
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulpcore/pulpcore/plugin/repo_version_utils.py", line 81, in validate_version_paths
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     raise ValueError(_("Cannot create repository version. {err}.").format(err=e))
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]: ValueError: Cannot create repository version. Path is duplicated: univocity-parsers-2.5.5-5.module_f28+3873+06cd63fa.noarch.rpm.
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]: Traceback (most recent call last):
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulpcore/pulpcore/plugin/repo_version_utils.py", line 79, in validate_version_paths
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     validate_file_paths(paths)
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:   File "/home/vagrant/devel/pulpcore/pulpcore/app/files.py", line 118, in validate_file_paths
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]:     raise ValueError(_("Path is duplicated: {path}").format(path=path))
Mar 06 19:39:45 pulp3-source-fedora31.rhgoose.example.com rq[22478]: ValueError: Path is duplicated: univocity-parsers-2.5.5-5.module_f28+3873+06cd63fa.noarch.rpm

Associated revisions

Revision 76f69116 View on GitHub
Added by Fabricio Aguiar 17 days ago

Properly compare modular content between versions

https://pulp.plan.io/issues/6303 closes #6303

Revision 8bf3cbcf View on GitHub
Added by Fabricio Aguiar 7 days ago

Properly compare modular content between versions

https://pulp.plan.io/issues/6303 closes #6303

(cherry picked from commit 76f6911624a7efbfc42f528286fdb00ebb7ed543)

History

#1 Updated by ttereshc 28 days ago

  • Priority changed from Normal to High

#2 Updated by ttereshc 28 days ago

  • Subject changed from Resyncing F31 repo raises ValueError: Path is duplicated to If same content is provided by 2 remotes, resync raises ValueError: Path is duplicated
  • Description updated (diff)

#3 Updated by ttereshc 22 days ago

  • Sprint/Milestone set to Pulp 3.x RPM (Katello release)

#4 Updated by ttereshc 22 days ago

  • Sprint set to Sprint 68

#5 Updated by ttereshc 22 days ago

  • Triaged changed from No to Yes

#6 Updated by fabricio.aguiar 17 days ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fabricio.aguiar

#7 Updated by fabricio.aguiar 17 days ago

  • Status changed from ASSIGNED to POST

#8 Updated by Anonymous 15 days ago

  • Status changed from POST to MODIFIED

#9 Updated by Anonymous 7 days ago

Please register to edit this issue

Also available in: Atom PDF