Project

Profile

Help

Issue #6230

closed

Ansible Check Mode does not work with ansible-pulp

Added by mdepaulo@redhat.com about 4 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

A quick look at the tasks in ansible-pulp that need check_mode:

  • command
  • shell
  • script

Shows that they do not have the appropriate lines (check_mode: false usually) (corrected this description from true) so that ansible can be run in check mode (--dry-run). i.e., the tasks that don't modify the system will not run at all, but later tasks depend on them, and will fail (or behave differently.)

Check Mode is a feature that users sometimes use, so we should fix these tasks.

https://docs.ansible.com/ansible/latest/user_guide/playbooks_checkmode.html

Our molecule-based CI does not catch this, because no part of it, not even converge, uses check_mode: https://github.com/ansible-community/molecule/issues/128

Actions #1

Updated by fao89 about 4 years ago

  • Triaged changed from No to Yes
Actions #2

Updated by fao89 about 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
Actions #3

Updated by mdepaulo@redhat.com about 4 years ago

  • Description updated (diff)
Actions #4

Updated by fao89 about 4 years ago

  • Status changed from ASSIGNED to POST

Added by Fabricio Aguiar about 4 years ago

Revision 4a807407 | View on GitHub

Testing check mode

https://pulp.plan.io/issues/6230 closes #6230

Added by Fabricio Aguiar about 4 years ago

Revision 4a807407 | View on GitHub

Testing check mode

https://pulp.plan.io/issues/6230 closes #6230

Actions #5

Updated by Anonymous about 4 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by Anonymous about 4 years ago

Actions #7

Updated by mdepaulo@redhat.com about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter almost 4 years ago

  • Category set to Installer - Moved to GitHub issues
  • Tags deleted (Pulp 3 installer)

Also available in: Atom PDF