Project

Profile

Help

Issue #6050

closed

Sync fails if remote has no Suite

Added by quba42 almost 3 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version - Debian:
master
Platform Release:
Target Release - Debian:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

pulp_deb currently assumes that the "Suite" field in Release files always exists.

The following suggests that a "Suite" field is optional in Release files:
https://wiki.debian.org/DebianRepository/Format#Suite

Repositories without a "Suite" field exist in the wild:
http://deb.tuxedocomputers.com/ubuntu/dists/bionic/

Attempting to sync such repositories causes an error:

pulp: rq.worker:ERROR: KeyError: 'Suite'

Even if the KeyError is fixed, some fall back value must be provided since "Suite" is a mandatory DB field in pulp_deb.

Option 1: Find some suitable default fall back value when a remote has no "Suite" field in it's Release file.
Option 2: Do not make the DB field mandatory.

Option 1 is very easy to implement, option 2 would require migrations and could mess up the plugin logic...

Actions #1

Updated by mdellweg almost 3 years ago

If it's going to be Option 2, it is the right time now to make backward incompatible database changes.

Actions #2

Updated by quba42 over 2 years ago

I may have been mistaken about the field being mandatory... Will add a PR.

Added by quba42 over 2 years ago

Revision 8ac4d825

Permit empy suite fields

fixes #6050 https://pulp.plan.io/issues/6050

Actions #4

Updated by quba42 over 2 years ago

  • Status changed from NEW to POST
Actions #5

Updated by quba42 over 2 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by quba42 over 1 year ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF