Project

Profile

Help

Story #5739

closed

As a user, advisory version is considered at conflict resolution time

Added by ttereshc about 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Background

Currently advisory conflicts resolve according to #4295 which is based on updated timestamp and package list difference.

Motivation

Some advisories don't have updated timestamp but they bump advisory version in case of changes. (e.g. openSUSE ones). RH/Fedora advisories bump version as well but not for all changes, so it's not possible to switch to using version only for conflict resolution.

Solution

Version of advisory should be taken into consideration at conflict resolution time.
Updated timestamp has precedence.
When updated timestamp is absent or the same for both advisories, advisory versions should be compared.
The higher the version is, the newer the advisory.

Actions #1

Updated by ttereshc over 4 years ago

  • Sprint/Milestone set to Pulp 3.x RPM (Katello 3.16)
Actions #2

Updated by ppicka over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions #3

Updated by pulpbot over 4 years ago

  • Status changed from ASSIGNED to POST
Actions #4

Updated by ttereshc over 4 years ago

  • Tags Pulp 3 RPM blocker added

Added by ppicka over 4 years ago

Revision 12b5738e | View on GitHub

Advisory version is taken to consideration

during sync when updated_dates are the same Pulp will check versions and if there is newer version it is added instead the old one.

generalize shared_utils 'is_previous_version' method to use it in comparison

closes #5739 https://pulp.plan.io/issues/5739

Actions #5

Updated by ppicka over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #6

Updated by dalley over 4 years ago

  • Sprint/Milestone changed from Pulp 3.x RPM (Katello 3.16) to Pulp RPM 3.3.0
Actions #7

Updated by dalley over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter over 4 years ago

  • Tags deleted (Pulp 3 RPM blocker)

Also available in: Atom PDF