Project

Profile

Help

Task #5609

closed

Convert CharField to TextField where it makes sense to do so

Added by dalley about 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Originally we had many TextFields that were converted to CharField because MySQL cannot index on TextField. However, it's no longer necessary after we decided to use PostgreSQL only.

Since "text" and "varchar" are identical in PostgreSQL, the only real benefit is removing the arbitrary 255 character limitation which is the maximum Django allows. Efficiency wise they are both essentially identical (technically speaking varchar is a little slower for the length checks).

For some fields like digests, it might make sense to keep the CharField with max length because it provides a little bit of schema information. But unless the field length actually needs to be bounded, TextField would make more sense.

Actions #1

Updated by dalley about 5 years ago

  • Status changed from NEW to ASSIGNED
Actions #2

Updated by dalley about 5 years ago

  • Assignee set to dalley
Actions #3

Updated by dalley about 5 years ago

  • Status changed from ASSIGNED to POST

Added by dalley about 5 years ago

Revision 8e8dcb8a | View on GitHub

Convert remaining CharField to TextField

closes: #5609 https://pulp.plan.io/issues/5609

Actions #4

Updated by dalley about 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #5

Updated by bmbouter almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #6

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF