Task #5609
closedConvert CharField to TextField where it makes sense to do so
100%
Description
Originally we had many TextFields that were converted to CharField because MySQL cannot index on TextField. However, it's no longer necessary after we decided to use PostgreSQL only.
Since "text" and "varchar" are identical in PostgreSQL, the only real benefit is removing the arbitrary 255 character limitation which is the maximum Django allows. Efficiency wise they are both essentially identical (technically speaking varchar is a little slower for the length checks).
For some fields like digests, it might make sense to keep the CharField with max length because it provides a little bit of schema information. But unless the field length actually needs to be bounded, TextField would make more sense.
Updated by dalley about 5 years ago
- Status changed from NEW to ASSIGNED
Added by dalley about 5 years ago
Updated by dalley about 5 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulpcore|8e8dcb8ab5287b60bbaa5f372ef27d7b61da8100.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Convert remaining CharField to TextField
closes: #5609 https://pulp.plan.io/issues/5609