Project

Profile

Help

Task #5550

closed

Remove "_type" / "pulp_type" as a public-facing field, and MasterModelSerializer

Added by dalley almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Rationale:

"_type" / "pulp_type" is a field that shows up on models using master-detail inheritance. However, there is no way to query these types generically. In order to query these types, you have to provide the app name and the type name, which are the two components of that field. Therefore it doesn't really provide the end user any valuable information.

This is probably a leftover relic from when the /content/ endpoint existed and returned content of all types.

Pulpcore still needs this information for various things, but, the user doesn't. Therefore we can remove it from the serializers.

"_type" / "pulp_type" is the only thing provided by MasterModelSerializer, so the whole thing can go. Everything inheriting from MasterModelSerializer can inherit from ModelSerializer instead.

https://github.com/pulp/pulpcore/blob/master/pulpcore/app/serializers/base.py#L81-L110


Related issues

Related to Pulp - Task #5454: rename _type to pulp_typeCLOSED - CURRENTRELEASEfao89

Actions
Actions #1

Updated by bmbouter almost 3 years ago

+1 I agree this information isn't valuable to users, and it likely restricts improvements we can make for them in the future.

Actions #2

Updated by dalley almost 3 years ago

  • Sprint/Milestone set to 3.0.0
Actions #3

Updated by fao89 almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fao89
Actions #4

Updated by fao89 almost 3 years ago

  • Related to Task #5454: rename _type to pulp_type added
Actions #5

Updated by fao89 almost 3 years ago

Docker uses _type:
https://github.com/pulp/pulp_docker/pull/424/commits/b4e3aed646d8e99c27a35a9a41586bcdcef88ed3
I'm wondering if I should remove _type on core and add it on docker serializers

Actions #7

Updated by Anonymous almost 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

Added by Fabricio Aguiar almost 3 years ago

Revision 57e1f2ca

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Actions #8

Updated by daviddavis almost 3 years ago

  • Status changed from MODIFIED to POST

Added by Fabricio Aguiar almost 3 years ago

Revision e69bba70

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Added by Fabricio Aguiar almost 3 years ago

Revision 3e4c9db8

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Added by Fabricio Aguiar almost 3 years ago

Revision 3e4c9db8

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Added by Fabricio Aguiar almost 3 years ago

Revision 3e4c9db8

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Added by Fabricio Aguiar almost 3 years ago

Revision 3e4c9db8

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Added by Fabricio Aguiar almost 3 years ago

Revision 507eee94

Removing _type field

ref #5550 https://pulp.plan.io/issues/5550

Actions #9

Updated by fao89 almost 3 years ago

  • Status changed from POST to MODIFIED
Actions #10

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF