Project

Profile

Help

Issue #5456

The current CI implementation makes it hard to discuss small changes to a bigger PR

Added by mdellweg about 1 month ago. Updated about 1 month ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

In the travisscripts, the commit messages of a pr are checked to conform to a specific format. If they do not conform, the scripts fail very early skipping all 'real' tests.
This makes it impossible to add incremental changes in individual commits (later to be squashed) to an existing PR while stilll get reports for failing tests.
If commit message validation was extracted as a separate test, one could use for example the git commit --fixup aabbccdd feature of git, while the validator would still block the merge button.

History

#1 Updated by fabricio.aguiar about 1 month ago

  • Triaged changed from No to Yes

#2 Updated by daviddavis about 1 month ago

Another option would be to just turn off the fail fast commit checks instead of breaking out a separate job. We're limited in Travis by the number of concurrent jobs across the entire pulp org.

Either way, I think this feature would be nice but my concern is that it'll tax our CI resources when developers carelessly push commits to their PRs. This might be something we could add after we move off Travis.

Please register to edit this issue

Also available in: Atom PDF