Project

Profile

Help

Issue #4810

closed

"force_full" should disable fast-forward instead of enabling

Added by Zhiming almost 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.20.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

It doesn't make sense that "force_full" enable fast-forward, so change it to be disable fast-forward.


Related issues

Related to Pulp - Issue #4799: Replace option "skip_fast_forward" with "force_full" for FileDistributorCLOSED - CURRENTRELEASEActions
Actions #1

Updated by daviddavis almost 5 years ago

  • Tags Pulp 2 added

Added by Zhiming almost 5 years ago

Revision d60bd2ea | View on GitHub

It doesn't make sense that "force_full" enable fast-forward, so change the opposite logic and enable fast-forward by default

ref #4810 https://pulp.plan.io/issues/4810

Fixing failed unit tests

Fixing failed unit tests and adding five unit tests for the method "publish_repo_fast_forward".

Besides that, improves "publish_repo_fast_forward" to delete symlinks that pointing files were removed, and the change also is covered by new unit tests.

Fixing PEP 8 issues

Actions #2

Updated by dkliban@redhat.com almost 5 years ago

  • Triaged changed from No to Yes
Actions #3

Updated by ttereshc over 4 years ago

  • Status changed from NEW to MODIFIED
  • Platform Release set to 2.20.0
Actions #4

Updated by ttereshc over 4 years ago

  • Sprint/Milestone set to 2.20.0
Actions #5

Updated by bherring over 4 years ago

  • Related to Issue #4799: Replace option "skip_fast_forward" with "force_full" for FileDistributor added
Actions #6

Updated by ttereshc over 4 years ago

  • Status changed from MODIFIED to 5
Actions #7

Updated by ttereshc over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

Also available in: Atom PDF