Actions
Issue #4733
closed
Pulp configured with S3 doesn't give users the Content-Disposition header
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 65
Quarter:
Description
Problem¶
After Pulp redirects the user to Amazon S3 to download the file the user receives it but it does not have the correct filename. The Artifact filename is something stored in Pulp's database. It's also possible that one Artifact is present in multiple repos as various filenames so this needs to be set as a per-request piece of data.
Solution¶
At the redirect time, we'll include the response-content-disposition=attachment; filename=abc.doc'; fragment. This is similar to what Galaxy already did before: https://github.com/ansible/galaxy/blob/devel/galaxy/api/download/views.py#L65
Actions
.
Have S3 and Azure redirect specify filename
The filename is specified as part of the redirect url.
This also changes the Handler's interface for the plugin writer, and there is a changelog entry with more details.
closes #4733 https://pulp.plan.io/issues/4733