Issue #4733
closed
Pulp configured with S3 doesn't give users the Content-Disposition header
Description
Problem¶
After Pulp redirects the user to Amazon S3 to download the file the user receives it but it does not have the correct filename. The Artifact filename is something stored in Pulp's database. It's also possible that one Artifact is present in multiple repos as various filenames so this needs to be set as a per-request piece of data.
Solution¶
At the redirect time, we'll include the response-content-disposition=attachment; filename=abc.doc'; fragment. This is similar to what Galaxy already did before: https://github.com/ansible/galaxy/blob/devel/galaxy/api/download/views.py#L65
Updated by newswangerd over 2 years ago
We're adding a download button in Automation Hub and this issue is causing all of our downloads in the browser to have unintelligible filenames.
Updated by bmbouter over 2 years ago
I've asked the question in django-storages upstream about how Pulp can configure this: https://github.com/jschneier/django-storages/issues/819
Updated by bmbouter over 2 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bmbouter
- Sprint set to Sprint 65
Adding to sprint because galaxy team is blocked by it.
Added by bmbouter over 2 years ago
Updated by bmbouter over 2 years ago
- Status changed from ASSIGNED to POST
PR available at: https://github.com/pulp/pulpcore/pull/522
Updated by bmbouter over 2 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|9f24cf976f683832313d6232651806a914dad443.
Updated by bmbouter over 2 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Have S3 and Azure redirect specify filename
The filename is specified as part of the redirect url.
This also changes the Handler's interface for the plugin writer, and there is a changelog entry with more details.
closes #4733 https://pulp.plan.io/issues/4733