Project

Profile

Help

Story #4172

closed

Remove duplicate tags from repository during sync

Added by amacdona@redhat.com about 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 46
Quarter:

Description

The docker plugin has repository version uniqueness constraints for Tags. For example the Tag with name "latest" points to a Manifest List. Another Tag with name "latest" (pointing to another Manifest List) cannot be added to the repository version while the first "latest" tag remains. Note: This repository version could have a "latest" that points to a manifest instead of a manifest list.

At this point, we don't think this uniqueness constraint can exist in the db, so we need to enforce the constraint at sync time (and later during add/remove.

During sync, before the new tags are added to the repository version, corresponding tags that are already in the repository version should be removed.

Heres an example:
RepositoryVersion1 contains a tag, "latest" which points to ManifestList1. A sync retrieves a new Tag "latest" that points to ManifestList2. Before "latest"-> ManifestList2 is added to the repository version, "latest"->ManifestList1 must be removed.

For implementation, this probably should be a new Stage, which could be the last item in the pipeline. (Add/remove stages are added outside of the plugin-defined pipeline.)


Related issues

Blocked by Pulp - Story #3934: As a plugin writer, I can have a stage that removes duplicatesCLOSED - CURRENTRELEASEamacdona@redhat.com

Actions
Copied to Container Support - Test #4299: Remove duplicate tags from repository during syncCLOSED - WONTFIXActions
Actions #1

Updated by ipanova@redhat.com about 4 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #2

Updated by amacdona@redhat.com almost 4 years ago

  • Related to Story #3934: As a plugin writer, I can have a stage that removes duplicates added
Actions #3

Updated by amacdona@redhat.com almost 4 years ago

  • Related to deleted (Story #3934: As a plugin writer, I can have a stage that removes duplicates)
Actions #4

Updated by amacdona@redhat.com almost 4 years ago

  • Blocked by Story #3934: As a plugin writer, I can have a stage that removes duplicates added
Actions #5

Updated by amacdona@redhat.com almost 4 years ago

  • Sprint set to Sprint 46
Actions #6

Updated by amacdona@redhat.com almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to amacdona@redhat.com

Added by amacdona@redhat.com almost 4 years ago

Revision 7f79cd73

Remove non-unique tag names during sync

When syncing, if a tag name references a different manifest/manifest list it must be removed from the repo. To do this simply, it was more convinient to split the Tag model into ManifestTag and ManifestListTag.

https://pulp.plan.io/issues/4172 fixes #4172

Added by amacdona@redhat.com almost 4 years ago

Revision f871b7d5

Distribute tags according to requested media type

Return the artifacts associated with a tag with type failover. Try manifest list first, then manifest schema 2. If both fail, log the warning and return a 404. This provides a convinient location for an on-the-fly schema converter.

These changes are necessary to use the split-tag models for distribution, so they will be merged as a part of #4172.

https://pulp.plan.io/issues/4172 re #4172

Added by amacdona@redhat.com almost 4 years ago

Revision 7f79cd73

Remove non-unique tag names during sync

When syncing, if a tag name references a different manifest/manifest list it must be removed from the repo. To do this simply, it was more convinient to split the Tag model into ManifestTag and ManifestListTag.

https://pulp.plan.io/issues/4172 fixes #4172

Added by amacdona@redhat.com almost 4 years ago

Revision f871b7d5

Distribute tags according to requested media type

Return the artifacts associated with a tag with type failover. Try manifest list first, then manifest schema 2. If both fail, log the warning and return a 404. This provides a convinient location for an on-the-fly schema converter.

These changes are necessary to use the split-tag models for distribution, so they will be merged as a part of #4172.

https://pulp.plan.io/issues/4172 re #4172

Added by amacdona@redhat.com almost 4 years ago

Revision 7f79cd73

Remove non-unique tag names during sync

When syncing, if a tag name references a different manifest/manifest list it must be removed from the repo. To do this simply, it was more convinient to split the Tag model into ManifestTag and ManifestListTag.

https://pulp.plan.io/issues/4172 fixes #4172

Added by amacdona@redhat.com almost 4 years ago

Revision f871b7d5

Distribute tags according to requested media type

Return the artifacts associated with a tag with type failover. Try manifest list first, then manifest schema 2. If both fail, log the warning and return a 404. This provides a convinient location for an on-the-fly schema converter.

These changes are necessary to use the split-tag models for distribution, so they will be merged as a part of #4172.

https://pulp.plan.io/issues/4172 re #4172

Added by amacdona@redhat.com almost 4 years ago

Revision 7f79cd73

Remove non-unique tag names during sync

When syncing, if a tag name references a different manifest/manifest list it must be removed from the repo. To do this simply, it was more convinient to split the Tag model into ManifestTag and ManifestListTag.

https://pulp.plan.io/issues/4172 fixes #4172

Added by amacdona@redhat.com almost 4 years ago

Revision f871b7d5

Distribute tags according to requested media type

Return the artifacts associated with a tag with type failover. Try manifest list first, then manifest schema 2. If both fail, log the warning and return a 404. This provides a convinient location for an on-the-fly schema converter.

These changes are necessary to use the split-tag models for distribution, so they will be merged as a part of #4172.

https://pulp.plan.io/issues/4172 re #4172

Actions #7

Updated by amacdona@redhat.com almost 4 years ago

  • Status changed from ASSIGNED to MODIFIED
  • % Done changed from 0 to 100
Actions #9

Updated by bherring almost 4 years ago

  • Copied to Test #4299: Remove duplicate tags from repository during sync added
Actions #10

Updated by bmbouter over 3 years ago

  • Tags deleted (Pulp 3)
Actions #11

Updated by ipanova@redhat.com about 3 years ago

  • Project changed from Docker Support to Container Support
Actions #12

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #13

Updated by ipanova@redhat.com almost 3 years ago

  • Sprint/Milestone set to 1.0.0

Also available in: Atom PDF