Actions
Issue #4140
closed
Puppet fails to find metadata file if there are multiple top-level files/dirs
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.18.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 45
Quarter:
Description
Steps to reproduce:
wget https://forge.puppet.com/v3/files/marcel-passenger-0.5.0.tar.gz
pulp-admin puppet repo create --repo-id marcelpuppet
pulp-admin puppet repo uploads upload --file marcel-passenger-0.5.0.tar.gz --repo-id marcelpuppet
pulp-admin puppet repo list
Result:
Task Failed
Could not find metadata file inside Puppet module
Related issues
Actions
.
Fixed bug where path wasn't used and module_dir was set to non-directory
There were two bugs here at play. First the code wasn't using the full path including extraction_dir when checking if the module file was a directory and secondly, the loop meant that module_dir could be set to a file if it didn't find a directory.
Also, fixed some flake8 errors.
fixes #4140 https://pulp.plan.io/issues/4140