Project

Profile

Help

Issue #4140

closed

Puppet fails to find metadata file if there are multiple top-level files/dirs

Added by daviddavis over 5 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.18.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 45
Quarter:

Description

Steps to reproduce:

wget https://forge.puppet.com/v3/files/marcel-passenger-0.5.0.tar.gz
pulp-admin puppet repo create --repo-id marcelpuppet
pulp-admin puppet repo uploads upload --file marcel-passenger-0.5.0.tar.gz --repo-id marcelpuppet
pulp-admin puppet repo list

Result:

Task Failed
Could not find metadata file inside Puppet module

Related issues

Related to Puppet Support - Issue #1846: pulp does not sync puppetforge correctlyCLOSED - CURRENTRELEASEdaviddavisActions
Actions #1

Updated by daviddavis over 5 years ago

  • Related to Issue #1846: pulp does not sync puppetforge correctly added
Actions #2

Updated by daviddavis over 5 years ago

  • Status changed from ASSIGNED to POST

Added by daviddavis over 5 years ago

Revision e1123708 | View on GitHub

Fixed bug where path wasn't used and module_dir was set to non-directory

There were two bugs here at play. First the code wasn't using the full path including extraction_dir when checking if the module file was a directory and secondly, the loop meant that module_dir could be set to a file if it didn't find a directory.

Also, fixed some flake8 errors.

fixes #4140 https://pulp.plan.io/issues/4140

Actions #3

Updated by daviddavis over 5 years ago

  • Subject changed from Puppet fails to find metadata file to Puppet fails to find metadata file if there are multiple top-level files/dirs
Actions #4

Updated by CodeHeeler over 5 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 45
Actions #5

Updated by daviddavis over 5 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by ttereshc over 5 years ago

  • Platform Release set to 2.18.0
Actions #7

Updated by ttereshc over 5 years ago

  • Sprint/Milestone set to 2.18.0
Actions #8

Updated by ttereshc over 5 years ago

  • Project changed from Pulp to Puppet Support
Actions #9

Updated by ttereshc over 5 years ago

  • Status changed from MODIFIED to 5
Actions #10

Updated by ttereshc over 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #11

Updated by kersom over 5 years ago

Actions #12

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF