Project

Profile

Help

Issue #4140

Puppet fails to find metadata file if there are multiple top-level files/dirs

Added by daviddavis about 1 year ago. Updated 7 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
2.18.0
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 45

Description

Steps to reproduce:

wget https://forge.puppet.com/v3/files/marcel-passenger-0.5.0.tar.gz
pulp-admin puppet repo create --repo-id marcelpuppet
pulp-admin puppet repo uploads upload --file marcel-passenger-0.5.0.tar.gz --repo-id marcelpuppet
pulp-admin puppet repo list

Result:

Task Failed
Could not find metadata file inside Puppet module

Related issues

Related to Puppet Support - Issue #1846: pulp does not sync puppetforge correctly CLOSED - CURRENTRELEASE Actions

Associated revisions

Revision e1123708 View on GitHub
Added by daviddavis about 1 year ago

Fixed bug where path wasn't used and module_dir was set to non-directory

There were two bugs here at play. First the code wasn't using the full
path including extraction_dir when checking if the module file was a
directory and secondly, the loop meant that module_dir could be set to
a file if it didn't find a directory.

Also, fixed some flake8 errors.

fixes #4140
https://pulp.plan.io/issues/4140

History

#1 Updated by daviddavis about 1 year ago

  • Related to Issue #1846: pulp does not sync puppetforge correctly added

#2 Updated by daviddavis about 1 year ago

  • Status changed from ASSIGNED to POST

#3 Updated by daviddavis about 1 year ago

  • Subject changed from Puppet fails to find metadata file to Puppet fails to find metadata file if there are multiple top-level files/dirs

#4 Updated by CodeHeeler about 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 45

#5 Updated by daviddavis about 1 year ago

  • Status changed from POST to MODIFIED

#6 Updated by ttereshc 12 months ago

  • Platform Release set to 2.18.0

#7 Updated by ttereshc 12 months ago

  • Sprint/Milestone set to 2.18.0

#8 Updated by ttereshc 12 months ago

  • Project changed from Pulp to Puppet Support

#9 Updated by ttereshc 12 months ago

  • Status changed from MODIFIED to ON_QA

#10 Updated by ttereshc 12 months ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

#11 Updated by kersom 11 months ago

#12 Updated by bmbouter 7 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF