Task #413: Our unit tests require read permissions on server.conf - Pulp

Actions

Send by e-mail Copy link

Task #413

closed

Our unit tests require read permissions on server.conf

Added by rbarlow about 9 years ago. Updated about 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

semyers

Category:

Sprint/Milestone:

Start date:

Due date:

% Done:

Estimated time:

Platform Release:

2.8.0

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Quarter:

Description

I attempted to fix our unit tests to not require reading server.conf, but it turns out that it is more effort than I want to do today to refactor how our configuration loading happens during unit tests.

Refactoring how we do configuration loading will be a very good thing to do in general, especially if we want to support virtualenv development.

For now, pulp-dev.py installs server.conf world-readable. When we find time to fix this bug, we should install server.conf as root:apache 640, just like the RPM. This way the development environment will more closely resemble the production environment, which will be a good thing.

+ This bug was cloned from Bugzilla Bug #1084708 +

Related issues

Actions

Copy link

Updated by rbarlow about 9 years ago

Due to https://bugzilla.redhat.com/show_bug.cgi?id=1176259 deleting my development database, I am raising the severity on this issue to high. If we make it so that /etc/pulp/server.conf can be installed at 640 (as it is in production), our dev environments will be more similar to production and we can also guarantee that the unit tests won't have access to our DB settings in order to do things like drop the database.

+ This comment was cloned from Bugzilla #1084708 comment 1 +

Actions

Copy link

Updated by rbarlow about 9 years ago

We likely have to fix #1160369 in order to fix this issue.

https://bugzilla.redhat.com/show_bug.cgi?id=1160369

+ This comment was cloned from Bugzilla #1084708 comment 2 +

Actions

Copy link

Updated by bmbouter about 9 years ago

Blocked by Issue #607: server/config.py reads server.conf when the module is loaded. added

Actions

Copy link

Updated by rbarlow over 8 years ago

Has duplicate Issue #1230: Ability to run unit tests on a system without pulp-server installed added

Actions

Copy link

Updated by semyers over 8 years ago

Status changed from NEW to ASSIGNED
Assignee set to semyers

Actions

Copy link

Updated by semyers over 8 years ago

server.conf permissions/existence is no longer required in core. For this issue to be complete, I'll be checking all the plugins' tests as well and making sure they're acting properly.

The change #607 is backward-compatible, so if any plugins are broken by an unreadable server.conf, it probably means that they're doing shady things to read the server conf.

Regarding this: "Refactoring how we do configuration loading will be a very good thing to do in general, especially if we want to support virtualenv development," #607 lays the groundwork for that. You can now modify the list of default config files before the config files are loaded, so that should be much easier to manage now.

Actions

Copy link

Updated by semyers over 8 years ago

it probably means that they're doing shady things to read the server conf

...or it just means they're using celery, because we try to read the server config before instantiating the global celery object. It's an easy fix, but one that need to be applied per-plugin test suite.

Added by semyers over 8 years ago

Revision d2286409 | View on GitHub

Block attempts to load server.conf when running unittests

Actions

Copy link