Project

Profile

Help

Issue #3952

closed

Using the ErrataRelatedModelSaver can result in creating incomplete content.

Added by jortel@redhat.com over 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 42
Quarter:

Description

The insert of errata and all of its related tables need to be committed atomically. A fatal exception or worker crash between stages can result in storing an incomplete Errata.


Related issues

Blocked by Pulp - Story #3953: ContentUnitSaver should support creating content with related models inside its transactionCLOSED - CURRENTRELEASEbmbouter

Actions
Actions #1

Updated by daviddavis over 4 years ago

  • Sprint/Milestone set to Pulp 3 RPM MVP
Actions #2

Updated by daviddavis over 4 years ago

  • Blocked by Story #3953: ContentUnitSaver should support creating content with related models inside its transaction added
Actions #3

Updated by bmbouter over 4 years ago

  • Tracker changed from Issue to Story
  • % Done set to 0

Converting to story per triage convo. Thanks for filing @jortel.

Actions #4

Updated by bmbouter about 4 years ago

  • Tracker changed from Story to Issue
  • Severity set to 2. Medium
  • Triaged set to No

The story work is happening in core, so I'm moving this to be a bugfix, which for pulp_rpm users it is.

Actions #5

Updated by bmbouter about 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
  • Sprint set to Sprint 42

Adding to sprint as part of rpm sync work.

Actions #6

Updated by bmbouter about 4 years ago

  • Status changed from ASSIGNED to POST

Added by bmbouter about 4 years ago

Revision 22d250ff

Use ContentUnitSaver _post_save hook

The ErrataRelatedModelSaver stage is instead repurposed as a subclass of the ContentUnitSaver stage. This is currently the best way for related objects to be saved within the same transaction.

Required PR: https://github.com/pulp/pulp/pull/3621

https://pulp.plan.io/issues/3952 closes #3952

asdf

Actions #7

Updated by CodeHeeler about 4 years ago

  • Triaged changed from No to Yes
Actions #8

Updated by bmbouter about 4 years ago

  • Status changed from POST to MODIFIED
Actions #9

Updated by bmbouter over 3 years ago

  • Tags deleted (Pulp 3)
Actions #10

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF