Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #3588

closed

Add MEDIA_ROOT option section to server.yaml

Added by daviddavis over 6 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Quarter:

Description

Add a comment section about MEDIA_ROOT so users can set it to another location:

https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/app/settings.py#L30

Related issues

Related to Pulp - Issue #3589: Settings in server.yaml have inconsistent namesCLOSED - CURRENTRELEASECodeHeelerActions
Actions
Copy link
 #1

Updated by daviddavis over 6 years ago

  • Project changed from Ansible Plugin to Pulp
Actions
Copy link
 #2

Updated by dalley over 6 years ago

Can't users simply override it in server.yaml? It's not currently a (commented out) option but there's no reason that I know of that you couldn't do that.

Actions
Copy link
 #3

Updated by daviddavis over 6 years ago

  • Tags Documentation added

Ah I assumed that it wasn't overridable because it is all uppercase. Any idea why some constants are all uppercase while others aren't (e.g. [0][1])?

Also, going to set this to a docs issue.

[0] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/etc/pulp/server.yaml#L87-L88
[1] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/etc/pulp/server.yaml#L103-L105

Actions
Copy link
 #4

Updated by daviddavis over 6 years ago

  • Subject changed from Users can't configure MEDIA_ROOT to Add MEDIA_ROOT section to server.yaml
Actions
Copy link
 #5

Updated by daviddavis over 6 years ago

  • Subject changed from Add MEDIA_ROOT section to server.yaml to Add MEDIA_ROOT option section to server.yaml
  • Description updated (diff)
Actions
Copy link
 #6

Updated by dalley over 6 years ago

Maybe we should verify that it does work properly. Unit test perhaps?

SECRET_KEY, though, is another constant that is all-caps but is (supposed to be) overrideable in settings.yaml.

This issue can probably just be satisfied by adding a commented-out entry for MEDIA_ROOT with a description.

Actions
Copy link
 #7

Updated by daviddavis over 6 years ago

  • Related to Issue #3589: Settings in server.yaml have inconsistent names added
Actions
Copy link
 #8

Updated by daviddavis over 6 years ago

I confirmed that setting MEDIA_ROOT in server.yaml works. +1 to adding an entry in server.yaml and closing this out.

Actions
Copy link
 #9

Updated by daviddavis over 6 years ago

  • Status changed from NEW to POST
  • Assignee set to daviddavis

Added by daviddavis over 6 years ago

Revision 50f209e9 | View on GitHub

Add documentation for MEDIA_ROOT setting

fixes #3588 https://pulp.plan.io/issues/3588

Added by daviddavis over 6 years ago

Revision 50f209e9 | View on GitHub

Add documentation for MEDIA_ROOT setting

fixes #3588 https://pulp.plan.io/issues/3588

Actions
Copy link
 #10

Updated by daviddavis over 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #11

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #12

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)
Actions
Copy link
 #13

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF