Project

Profile

Help

Issue #3588

Add MEDIA_ROOT option section to server.yaml

Added by daviddavis over 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

Add a comment section about MEDIA_ROOT so users can set it to another location:

https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/app/settings.py#L30


Related issues

Related to Pulp - Issue #3589: Settings in server.yaml have inconsistent names MODIFIED Actions

Associated revisions

Revision 50f209e9 View on GitHub
Added by daviddavis over 1 year ago

Add documentation for MEDIA_ROOT setting

fixes #3588
https://pulp.plan.io/issues/3588

Revision 50f209e9 View on GitHub
Added by daviddavis over 1 year ago

Add documentation for MEDIA_ROOT setting

fixes #3588
https://pulp.plan.io/issues/3588

Revision 50f209e9 View on GitHub
Added by daviddavis over 1 year ago

Add documentation for MEDIA_ROOT setting

fixes #3588
https://pulp.plan.io/issues/3588

History

#1 Updated by daviddavis over 1 year ago

  • Project changed from Ansible Plugin to Pulp

#2 Updated by dalley over 1 year ago

Can't users simply override it in server.yaml? It's not currently a (commented out) option but there's no reason that I know of that you couldn't do that.

#3 Updated by daviddavis over 1 year ago

  • Tags Documentation added

Ah I assumed that it wasn't overridable because it is all uppercase. Any idea why some constants are all uppercase while others aren't (e.g. [0][1])?

Also, going to set this to a docs issue.

[0] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/etc/pulp/server.yaml#L87-L88
[1] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/etc/pulp/server.yaml#L103-L105

#4 Updated by daviddavis over 1 year ago

  • Subject changed from Users can't configure MEDIA_ROOT to Add MEDIA_ROOT section to server.yaml

#5 Updated by daviddavis over 1 year ago

  • Subject changed from Add MEDIA_ROOT section to server.yaml to Add MEDIA_ROOT option section to server.yaml
  • Description updated (diff)

#6 Updated by dalley over 1 year ago

Maybe we should verify that it does work properly. Unit test perhaps?

SECRET_KEY, though, is another constant that is all-caps but is (supposed to be) overrideable in settings.yaml.

This issue can probably just be satisfied by adding a commented-out entry for MEDIA_ROOT with a description.

#7 Updated by daviddavis over 1 year ago

  • Related to Issue #3589: Settings in server.yaml have inconsistent names added

#8 Updated by daviddavis over 1 year ago

I confirmed that setting MEDIA_ROOT in server.yaml works. +1 to adding an entry in server.yaml and closing this out.

#9 Updated by daviddavis over 1 year ago

  • Status changed from NEW to POST
  • Assignee set to daviddavis

#10 Updated by daviddavis over 1 year ago

  • Status changed from POST to MODIFIED

#11 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#12 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)

Please register to edit this issue

Also available in: Atom PDF