Issue #3587: Multiple serializers doesn't work for detail viewsets types - Pulp

Actions

Send by e-mail Copy link

Issue #3587

closed

Multiple serializers doesn't work for detail viewsets types

Added by dalley almost 6 years ago. Updated over 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dalley

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 37

Quarter:

Description

In the "NamedModelViewSet", we overrode "get_serializer_class()" so that derivative viewsets like TaskViewSet can define different serializers for different actions. This works for Task, but it does not work for viewsets derived from other viewsets.

For instance, it is non-functional on PythonPackageContentViewSet, which inherits from ContentViewSet, which inherits from NamedModelViewSet.

Actions

Copy link

Updated by amacdona@redhat.com almost 6 years ago

dalley, so we need to move the get_serializer_class override out of the base class and into the TaskSerializer?

Actions

Copy link

Updated by amacdona@redhat.com almost 6 years ago

also, what specific errors does this cause?

Actions

Copy link

Updated by amacdona@redhat.com almost 6 years ago

Triaged changed from No to Yes
Sprint set to Sprint 36

Actions

Copy link

Updated by dalley almost 6 years ago

There were no errors, but the multiple serializers part did not work for me. It just used the "default" serializer class for everything. Not fully sure why or how best to solve it since I didn't dig too deep at the time.

Actions

Copy link