Actions
Issue #3475
closed
Invalid base path error could be more helpful
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 36
Quarter:
Description
Create a distributor with a space in its base path and you'll get an error message saying ""Enter a valid URL." We're using django's URLValidator which produces this message:
https://github.com/django/django/blob/master/django/core/validators.py#L102
We ought to raise a more informative message about what constitutes a valid url path.
Relevant PR:
Updated by amacdona@redhat.com about 6 years ago
- Project changed from File Support to Pulp
Updated by dalley about 6 years ago
- Triaged changed from No to Yes
- Tags Easy Fix added
Updated by CodeHeeler about 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to CodeHeeler
Updated by CodeHeeler almost 6 years ago
- Status changed from ASSIGNED to POST
Added by CodeHeeler almost 6 years ago
Added by CodeHeeler almost 6 years ago
Revision 9a9e9c93 | View on GitHub
Provide more informative invalid base path error
Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.
Updated by CodeHeeler almost 6 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|9a9e9c931973f654cd951fa2030d62f4d5ebd349.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
.
Provide more informative invalid base path error
Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.
fixes #3475 https://pulp.plan.io/issues/3475