Issue #3475: Invalid base path error could be more helpful - Pulp

Send by e-mail

Issue #3475

Invalid base path error could be more helpful

Added by daviddavis over 2 years ago. Updated 8 months ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

CodeHeeler

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Easy Fix

Sprint:

Sprint 36

Description

Create a distributor with a space in its base path and you'll get an error message saying ""Enter a valid URL." We're using django's URLValidator which produces this message:

https://github.com/django/django/blob/master/django/core/validators.py#L102

We ought to raise a more informative message about what constitutes a valid url path.

Relevant PR:

https://github.com/pulp/pulp/pull/3371

Associated revisions

Revision 9a9e9c93 View on GitHub
Added by CodeHeeler over 2 years ago

Provide more informative invalid base path error

Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.

fixes #3475 https://pulp.plan.io/issues/3475

Revision 9a9e9c93 View on GitHub
Added by CodeHeeler over 2 years ago

Provide more informative invalid base path error

Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.

fixes #3475 https://pulp.plan.io/issues/3475