Issue #3475
Invalid base path error could be more helpful
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 36
Quarter:
Description
Create a distributor with a space in its base path and you'll get an error message saying ""Enter a valid URL." We're using django's URLValidator which produces this message:
https://github.com/django/django/blob/master/django/core/validators.py#L102
We ought to raise a more informative message about what constitutes a valid url path.
Relevant PR:
Associated revisions
Revision 9a9e9c93
View on GitHub
Provide more informative invalid base path error
Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.
History
#1
Updated by amacdona@redhat.com almost 3 years ago
- Project changed from File Support to Pulp
#2
Updated by dalley almost 3 years ago
- Triaged changed from No to Yes
- Tags Easy Fix added
#3
Updated by amacdona@redhat.com almost 3 years ago
- Tags deleted (
Pulp 3 MVP)
#4
Updated by CodeHeeler almost 3 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to CodeHeeler
#5
Updated by CodeHeeler almost 3 years ago
- Sprint set to Sprint 35
#6
Updated by CodeHeeler over 2 years ago
- Status changed from ASSIGNED to POST
#7
Updated by rchan over 2 years ago
- Sprint changed from Sprint 35 to Sprint 36
#8
Updated by CodeHeeler over 2 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|9a9e9c931973f654cd951fa2030d62f4d5ebd349.
#9
Updated by daviddavis over 1 year ago
- Sprint/Milestone set to 3.0.0
#10
Updated by bmbouter over 1 year ago
- Tags deleted (
Pulp 3)
#11
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Provide more informative invalid base path error
Default message provided by Django's URLValidator is simply: "Enter a valid URL" Check for spaces in path before this call and raise ValidationError if found.
fixes #3475 https://pulp.plan.io/issues/3475