Project

Profile

Help

Issue #3475

Invalid base path error could be more helpful

Added by daviddavis over 1 year ago. Updated 8 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 36

Description

Create a distributor with a space in its base path and you'll get an error message saying ""Enter a valid URL." We're using django's URLValidator which produces this message:

https://github.com/django/django/blob/master/django/core/validators.py#L102

We ought to raise a more informative message about what constitutes a valid url path.

Relevant PR:

https://github.com/pulp/pulp/pull/3371

Associated revisions

Revision 9a9e9c93 View on GitHub
Added by CodeHeeler over 1 year ago

Provide more informative invalid base path error

Default message provided by Django's URLValidator is simply:
"Enter a valid URL"
Check for spaces in path before this call and raise ValidationError
if found.

fixes #3475
https://pulp.plan.io/issues/3475

Revision 9a9e9c93 View on GitHub
Added by CodeHeeler over 1 year ago

Provide more informative invalid base path error

Default message provided by Django's URLValidator is simply:
"Enter a valid URL"
Check for spaces in path before this call and raise ValidationError
if found.

fixes #3475
https://pulp.plan.io/issues/3475

History

#1 Updated by amacdona@redhat.com over 1 year ago

  • Project changed from File Support to Pulp

#2 Updated by dalley over 1 year ago

  • Triaged changed from No to Yes
  • Tags Easy Fix added

#3 Updated by amacdona@redhat.com over 1 year ago

  • Tags deleted (Pulp 3 MVP)

#4 Updated by CodeHeeler over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to CodeHeeler

#5 Updated by CodeHeeler over 1 year ago

  • Sprint set to Sprint 35

#6 Updated by CodeHeeler over 1 year ago

  • Status changed from ASSIGNED to POST

#7 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 35 to Sprint 36

#8 Updated by CodeHeeler over 1 year ago

  • Status changed from POST to MODIFIED

#9 Updated by daviddavis 8 months ago

  • Sprint/Milestone set to 3.0

#10 Updated by bmbouter 8 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF