Project

Profile

Help

Issue #3355

closed

Getting an error building docs with Sphinx 1.7

Added by daviddavis almost 7 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 32
Quarter:

Description

A new version of sphinx was released today and it fails to build our docs:

/home/vagrant/devel/pulp/pulpcore/pulpcore/app/serializers/base.py:docstring of pulpcore.app.serializers.base.ModelSerializer.create:5:Inline strong start-string without end-string.

This previously worked with Sphinx 1.6.7.

Actions #1

Updated by daviddavis almost 7 years ago

Here are the lines causing the problems:

https://github.com/encode/django-rest-framework/blob/master/rest_framework/serializers.py#L888
https://github.com/encode/django-rest-framework/blob/master/rest_framework/serializers.py#L895

Escaping the asterisks in my local copy of this file with backslashes fixed the problem for me.

Actions #2

Updated by dalley almost 7 years ago

  • Sprint/Milestone set to 54
  • Triaged changed from No to Yes
Actions #3

Updated by daviddavis almost 7 years ago

One thing I found that fixes the problem is to add docstring to ModelSerializer.create[0]. It looks like this prevents sphinx from looking up and parsing the docstring from DRF's ModelSerializer.create method (which has the offending problem). I don't think this is a good long-term solution though.

[0] https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/app/serializers/base.py#L105

Actions #4

Updated by bizhang almost 7 years ago

I opened a PR to upstream django-rest-framework, but it was rejected :(
https://github.com/encode/django-rest-framework/pull/5832

I think the next best solution is to go with @daviddavis's proposal in https://pulp.plan.io/issues/3355#note-3

Added by werwty almost 7 years ago

Revision f6be2d71 | View on GitHub

Add docstring to fix Sphinx 1.7

closes #3355 https://pulp.plan.io/issues/3355

Added by werwty almost 7 years ago

Revision f6be2d71 | View on GitHub

Add docstring to fix Sphinx 1.7

closes #3355 https://pulp.plan.io/issues/3355

Actions #5

Updated by bizhang almost 7 years ago

  • Status changed from NEW to POST
  • Assignee set to bizhang
Actions #6

Updated by werwty almost 7 years ago

  • Status changed from POST to MODIFIED
Actions #7

Updated by bmbouter over 6 years ago

  • Sprint set to Sprint 32
Actions #8

Updated by bmbouter over 6 years ago

  • Sprint/Milestone deleted (54)
Actions #9

Updated by dkliban@redhat.com over 6 years ago

  • Sprint/Milestone set to 3.0.0
Actions #10

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)
Actions #11

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF