docker tag creation: inconsistent field names
As a user of the REST API uploading a unit, I expect to look at the model's field names to find out what I'm supposed to upload.
The Tag model has a 'manifest_digest' field.
However, the upload code expects a 'digest' field:
Consistency would be nice, if it's not too much to ask.
Updated by firstname.lastname@example.org almost 6 years ago
Even though it is and easy code change, it looks like a backwards incompatible change because of the change of the field name from 'digest' to 'manifest_digest' which leads to violation of semantic versioning. CLI should also be considered for consistency in this case.
$ pulp-admin -vv docker repo tag Command: tag Description: create or update a tag to point to a manifest Available Arguments: --bg - if specified, the client process will end immediately (the task will continue to run on the server) --repo-id - (required) unique identifier; only alphanumeric, ., -, and _ allowed -v - display extra information about the upload process --tag-name - (required) name of the tag to create or update --digest - (required) digest of the image manifest or manifest list (e.g. sha256:3e006...) The following options are required but were not specified: --repo-id --tag-name --digest