Actions
Issue #3250
closeddocker tag creation: inconsistent field names
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version - Docker:
Platform Release:
2.15.1
Target Release - Docker:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:
Description
As a user of the REST API uploading a unit, I expect to look at the model's field names to find out what I'm supposed to upload.
The Tag model has a 'manifest_digest' field.
However, the upload code expects a 'digest' field:
https://github.com/pulp/pulp_docker/blob/master/plugins/pulp_docker/plugins/importers/upload.py#L331
Consistency would be nice, if it's not too much to ask.
Actions
Prefer manifest_digest over digest, the actual field name on the model.
Raise a validation exception if name or manifest_digest are missing. Added tests.
closes #3250 https://pulp.plan.io/issues/3250