Story #3119: As a user, I can see in logs that force_full option for sync or publish is enabled - Pulp

Actions

Send by e-mail Copy link

Story #3119

closed

As a user, I can see in logs that force_full option for sync or publish is enabled

Added by ttereshc over 5 years ago. Updated almost 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dalley

Category:

Sprint/Milestone:

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

2.15.0

Groomed:

Yes

Sprint Candidate:

Yes

Tags:

Pulp 2

Sprint:

Sprint 28

Quarter:

Description

It is possible that users configure importer/distributor to have force_full enabled and forget about it.
For example, Katello users can enable "force_full" sync or publish. This is usually done as part of debugging, but it's easy to set it and then forget to turn it off. The issue is not apparent until later on when there are performance issues with sync/publish.

Logging that force_full is used would help with debugging performance issues.

Log at INFO level and only when force_full option is set to True.
Message should specify the behavior the enabled option causes, e.g.:
- "fully resyncing due to use of force_full importer setting"
- "fully republishing due to use of force_full distributor setting"

Actions

Copy link

Updated by ttereshc over 5 years ago

I think it can be useful because force_full is not supposed to be used every time but for certain cases.
I suggest to use INFO log level.

Actions

Copy link

Updated by mhrivnak over 5 years ago

Agreed. This option changes the behavior of the task substantially, so I think it's reasonable to log at INFO. I suggest only logging a message when it is set to true, and focus the message on the behavior. Something like "fully republishing due to use of force_full setting".

Actions

Copy link