Project

Profile

Help

Task #3025

closed

natural key fields are defined in two places

Added by dkliban@redhat.com about 7 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 26
Quarter:

Description

All models inheriting from Content define a 'unique together' set of fields. Content model also has a natural_key_fields tuple. As a result we have uniqueness defined in two place. To keep things DRY we should only define the uniqueness as part of the class Meta. Example of how this can work is already implemented in pulp_example[0].

[0] https://github.com/dkliban/pulp_example/blob/master/pulp_example/app/models.py#L89

Actions #1

Updated by dkliban@redhat.com about 7 years ago

  • Sprint Candidate changed from No to Yes
  • Tags Pulp 3 added
Actions #2

Updated by mhrivnak about 7 years ago

  • Tracker changed from Issue to Task
  • Sprint/Milestone set to 45
  • % Done set to 0
  • Groomed changed from No to Yes
Actions #3

Updated by daviddavis about 7 years ago

  • Assignee set to daviddavis
Actions #4

Updated by daviddavis about 7 years ago

  • Status changed from NEW to ASSIGNED

Added by daviddavis about 7 years ago

Revision b90034a0 | View on GitHub

Removing natural key fields attribute

refs #3025 https://pulp.plan.io/issues/3025

Actions #6

Updated by daviddavis about 7 years ago

  • Status changed from POST to MODIFIED
Actions #7

Updated by bmbouter over 6 years ago

  • Sprint set to Sprint 26
Actions #8

Updated by bmbouter over 6 years ago

  • Sprint/Milestone deleted (45)
Actions #9

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #10

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions #11

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF