Project

Profile

Help

Task #3025

natural key fields are defined in two places

Added by dkliban@redhat.com about 2 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 26

Description

All models inheriting from Content define a 'unique together' set of fields. Content model also has a natural_key_fields tuple. As a result we have uniqueness defined in two place. To keep things DRY we should only define the uniqueness as part of the class Meta. Example of how this can work is already implemented in pulp_example0.

[0] https://github.com/dkliban/pulp_example/blob/master/pulp_example/app/models.py#L89


Checklist

Associated revisions

Revision b90034a0 View on GitHub
Added by daviddavis about 2 years ago

Removing natural key fields attribute

refs #3025
https://pulp.plan.io/issues/3025

History

#1 Updated by dkliban@redhat.com about 2 years ago

  • Sprint Candidate changed from No to Yes
  • Tags Pulp 3 added

#2 Updated by mhrivnak about 2 years ago

  • Tracker changed from Issue to Task
  • Sprint/Milestone set to 45
  • % Done set to 0
  • Groomed changed from No to Yes

#3 Updated by daviddavis about 2 years ago

  • Assignee set to daviddavis

#4 Updated by daviddavis about 2 years ago

  • Status changed from NEW to ASSIGNED

#6 Updated by daviddavis about 2 years ago

  • Status changed from POST to MODIFIED

#7 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 26

#8 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (45)

#9 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#10 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF