Project

Profile

Help

Issue #3014

closed

Counters for added content are incorrect in case of download failures

Added by ttereshc over 6 years ago. Updated about 2 years ago.

Status:
CLOSED - DUPLICATE
Priority:
High
Assignee:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Ticket moved to GitHub: "pulp/pulp_file/604":https://github.com/pulp/pulp_file/issues/604


To reproduce: sync repo which misses some files (3 present, 2 missing): https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/PULP_MANIFEST

Check progress report (Added content states that 5 files were added).
Maybe total = 5 and done = 3 would make more sense.

HTTP 200 OK
Allow: GET, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "_href": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/",
    "group": null,
    "state": "completed",
    "started_at": "2017-09-14T23:48:35.283677Z",
    "finished_at": "2017-09-14T23:48:36.977364Z",
    "non_fatal_errors": [
        {
            "traceback": null,
            "code": null,
            "description": "HttpDownload: id=5808 url=https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/missing-1.iso writer=missing-1.iso | repair: retries=1 | timeout: connect=10 read=30 | ssl: validation=False CA= key= certificate= | User: name= password= | proxy= headers={} - Failed. Reason: HTTP [404]"
        },
        {
            "traceback": null,
            "code": null,
            "description": "HttpDownload: id=5960 url=https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/missing-2.iso writer=missing-2.iso | repair: retries=1 | timeout: connect=10 read=30 | ssl: validation=False CA= key= certificate= | User: name= password= | proxy= headers={} - Failed. Reason: HTTP [404]"
        }
    ],
    "error": null,
    "worker": "http://127.0.0.1:8000/api/v3/workers/reserved_resource_worker_2@pulp3/",
    "parent": null,
    "tags": [],
    "progress_reports": [
        {
            "message": "Add Content",
            "state": "completed",
            "total": 5,
            "done": 5,
            "suffix": "",
            "task": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/"
        },
        {
            "message": "Remove Content",
            "state": "completed",
            "total": 0,
            "done": 0,
            "suffix": "",
            "task": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/"
        }
    ]
}

Related issues

Has duplicate File Support - Issue #3037: sync progress reports all units added when errors downloading occurCLOSED - DUPLICATEActions
Actions #1

Updated by ttereshc over 6 years ago

  • Priority changed from Normal to High
  • Severity changed from 2. Medium to 3. High
  • Triaged changed from No to Yes
Actions #2

Updated by jortel@redhat.com over 6 years ago

The progress report is not a summary report. It only communicates progress. In this case, it reported that it had 5 things to do and it completed 5 which is correct. Done != Succeeded. The progress report only tells the user how far along things are and potentially how long the user should expect to wait.

This should be closed as NOT-A-BUG.

Actions #3

Updated by dkliban@redhat.com over 6 years ago

  • Has duplicate Issue #3037: sync progress reports all units added when errors downloading occur added
Actions #4

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #5

Updated by pulpbot about 2 years ago

  • Description updated (diff)
  • Status changed from NEW to CLOSED - DUPLICATE

Also available in: Atom PDF