Project

Profile

Help

Send by e-mail

Story #2984

As an API user, I get user friendly feedback when I use an invalid value

Added by daviddavis about 2 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
bizhang
Category:
-
Sprint/Milestone:
3.0
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
882
Verified:
No
Verification Required:
No
Sprint:
Sprint 27

Description

There are several places in Pulp 3 where we ought to be using validation but are not. Here are a few examples with reproducers:

https://pulp.plan.io/issues/2974
https://pulp.plan.io/issues/2975
https://pulp.plan.io/issues/2976

There may be more issues too. Instead of opening individual bugs/tasks, this story is go through the API and add validation for any existing fields that need it.

Hide closed

Checklist

Related issues

Related to Pulp - Issue #2976: 500 error when I try to create a username with more than 150 chars CLOSED - DUPLICATE Actions
Duplicated by Pulp - Issue #2975: Username field doesn't validate characters CLOSED - DUPLICATE Actions
Duplicated by Pulp - Issue #2974: Error when attempting to create two repos with the same name CLOSED - DUPLICATE Actions

Associated revisions

Revision 36e840c7 View on GitHub
Added by werwty about 2 years ago

Add uniquenessand length validators to serializer fields.

Move username regex validator from model to serializer, since the model validation
does not run automatically on model save:
https://docs.djangoproject.com/en/dev/ref/validators/#how-validators-are-run

Note: For the importer and publisher uniqueness validator to take effect they must
be declared on the Plugin importer and publisher class like so:

Class PluginPublisherSerializer(pulpcore.plugin.serializers.PublisherSerializer):
class Meta:
validators = PublisherSerializer.Meta.validators

closes #2984
https://pulp.plan.io/issues/2984

Revision 36e840c7 View on GitHub
Added by werwty about 2 years ago

Add uniquenessand length validators to serializer fields.

Move username regex validator from model to serializer, since the model validation
does not run automatically on model save:
https://docs.djangoproject.com/en/dev/ref/validators/#how-validators-are-run

Note: For the importer and publisher uniqueness validator to take effect they must
be declared on the Plugin importer and publisher class like so:

Class PluginPublisherSerializer(pulpcore.plugin.serializers.PublisherSerializer):
class Meta:
validators = PublisherSerializer.Meta.validators

closes #2984
https://pulp.plan.io/issues/2984

Revision 36e840c7 View on GitHub
Added by werwty about 2 years ago

Add uniquenessand length validators to serializer fields.

Move username regex validator from model to serializer, since the model validation
does not run automatically on model save:
https://docs.djangoproject.com/en/dev/ref/validators/#how-validators-are-run

Note: For the importer and publisher uniqueness validator to take effect they must
be declared on the Plugin importer and publisher class like so:

Class PluginPublisherSerializer(pulpcore.plugin.serializers.PublisherSerializer):
class Meta:
validators = PublisherSerializer.Meta.validators

closes #2984
https://pulp.plan.io/issues/2984

Revision 67ebef1e View on GitHub
Added by werwty about 2 years ago

Add validators for importer and publisher

re #2984

Revision 67ebef1e View on GitHub
Added by werwty about 2 years ago

Add validators for importer and publisher

re #2984

History

#1 Updated by daviddavis about 2 years ago

  • Duplicated by Issue #2975: Username field doesn't validate characters added

#2 Updated by daviddavis about 2 years ago

  • Related to Issue #2976: 500 error when I try to create a username with more than 150 chars added

#3 Updated by daviddavis about 2 years ago

  • Duplicated by Issue #2974: Error when attempting to create two repos with the same name added

#4 Updated by daviddavis about 2 years ago

  • Tags Pulp 3 added

#5 Updated by amacdona@redhat.com about 2 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

I am seeing a 500 for duplicates across the board. The serializers do not check for uniqueness and the db error bubbles up.

#6 Updated by mhrivnak about 2 years ago

  • Sprint/Milestone set to 45

#7 Updated by bizhang about 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bizhang

#8 Updated by jortel@redhat.com about 2 years ago

  • Sprint/Milestone changed from 45 to 46

#9 Updated by bizhang about 2 years ago

  • Status changed from ASSIGNED to POST

#10 Updated by werwty about 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#11 Updated by daviddavis over 1 year ago

  • Smash Test set to 882

#12 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 27

#13 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (46)

#14 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#15 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Send by e-mail

Also available in: Atom PDF