Project

Profile

Help

Issue #2977

closed

Attributes on KeyValueRelatedFields are not used by DRF

Added by bizhang over 7 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 24
Quarter:

Description

Attributes on NotesKeyValueRelatedField[0] does not get picked up by DRF. This is evidenced by the help_text not showing up, and by DRF returning "This field is required." even when required is set to False.

If required is set to False on initialization of Notes field in the RepositorySeralizer[1]

notes = NotesKeyValueRelatedField(required=False)

DRF then picks up this field.

[0] https://github.com/pulp/pulp/blob/3.0-dev/platform/pulpcore/app/serializers/generic.py#L16
[1] https://github.com/pulp/pulp/blob/3.0-dev/platform/pulpcore/app/serializers/repository.py#L40


Related issues

Related to Pulp - Issue #2947: Notes field on the Repository model should default to {}CLOSED - WONTFIXdaviddavisActions
Actions #1

Updated by amacdona@redhat.com over 7 years ago

  • Related to Issue #2947: Notes field on the Repository model should default to {} added
Actions #2

Updated by ttereshc over 7 years ago

  • Sprint/Milestone set to 43
  • Triaged changed from No to Yes
Actions #3

Updated by bizhang over 7 years ago

  • Status changed from NEW to POST
  • Assignee set to bizhang

Added by werwty over 7 years ago

Revision 43ab81a0 | View on GitHub

Remove Scratchpad and KeyValueRelatedFields

closes #2977 closes #2817

https://pulp.plan.io/issues/2977 https://pulp.plan.io/issues/2817

Added by werwty over 7 years ago

Revision 43ab81a0 | View on GitHub

Remove Scratchpad and KeyValueRelatedFields

closes #2977 closes #2817

https://pulp.plan.io/issues/2977 https://pulp.plan.io/issues/2817

Actions #4

Updated by werwty about 7 years ago

  • Status changed from POST to MODIFIED
Actions #5

Updated by bmbouter over 6 years ago

  • Sprint set to Sprint 24
Actions #6

Updated by bmbouter over 6 years ago

  • Sprint/Milestone deleted (43)
Actions #7

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #8

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions #9

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF