Project

Profile

Help

Send by e-mail

Issue #2977

Attributes on KeyValueRelatedFields are not used by DRF

Added by bizhang almost 3 years ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
bizhang
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 24

Description

Attributes on NotesKeyValueRelatedField[0] does not get picked up by DRF. This is evidenced by the help_text not showing up, and by DRF returning "This field is required." even when required is set to False.

If required is set to False on initialization of Notes field in the RepositorySeralizer[1]

notes = NotesKeyValueRelatedField(required=False)

DRF then picks up this field.

[0] https://github.com/pulp/pulp/blob/3.0-dev/platform/pulpcore/app/serializers/generic.py#L16
[1] https://github.com/pulp/pulp/blob/3.0-dev/platform/pulpcore/app/serializers/repository.py#L40

Related issues

Related to Pulp - Issue #2947: Notes field on the Repository model should default to {} CLOSED - WONTFIX Actions

Associated revisions

Revision 43ab81a0 View on GitHub
Added by werwty almost 3 years ago

Remove Scratchpad and KeyValueRelatedFields

closes #2977 closes #2817

https://pulp.plan.io/issues/2977 https://pulp.plan.io/issues/2817

Revision 43ab81a0 View on GitHub
Added by werwty almost 3 years ago

Remove Scratchpad and KeyValueRelatedFields

closes #2977 closes #2817

https://pulp.plan.io/issues/2977 https://pulp.plan.io/issues/2817

History

#1 Updated by amacdona@redhat.com almost 3 years ago

  • Related to Issue #2947: Notes field on the Repository model should default to {} added

#2 Updated by ttereshc almost 3 years ago

  • Sprint/Milestone set to 43
  • Triaged changed from No to Yes

#3 Updated by bizhang almost 3 years ago

  • Status changed from NEW to POST
  • Assignee set to bizhang

#4 Updated by werwty almost 3 years ago

  • Status changed from POST to MODIFIED

#5 Updated by bmbouter about 2 years ago

  • Sprint set to Sprint 24

#6 Updated by bmbouter about 2 years ago

  • Sprint/Milestone deleted (43)

#7 Updated by daviddavis about 1 year ago

  • Sprint/Milestone set to 3.0.0

#8 Updated by bmbouter about 1 year ago

  • Tags deleted (Pulp 3)

#9 Updated by bmbouter 5 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Send by e-mail

Also available in: Atom PDF