Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #2963

closed

Use the new lower case celery config settings

Added by daviddavis over 6 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
jwelborn
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Quarter:

Description

Celery 4 introduces new config settings with better naming. More info:

http://docs.celeryproject.org/en/latest/userguide/configuration.html#new-lowercase-settings

Actions
Copy link
 #1

Updated by daviddavis over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by daviddavis over 6 years ago

  • Tags Easy Fix added
Actions
Copy link
 #3

Updated by ttereshc over 6 years ago

  • Tracker changed from Issue to Refactor
  • % Done set to 0
Actions
Copy link
 #4

Updated by jwelborn over 6 years ago

Hi, I found this issue browsing looking for easy fixes.

Is this just changing the names here to the lowercase celery 4 names?

If so, can I help?

Actions
Copy link
 #5

Updated by bizhang over 6 years ago

Actions
Copy link
 #6

Updated by jwelborn over 6 years ago

Since this is a pulp 3 fix, should I pull against 3.0-dev?

Actions
Copy link
 #7

Updated by bizhang over 6 years ago

Actions
Copy link
 #8

Updated by jwelborn over 6 years ago

Just to make sure I'm not oversimplifying this:

All that's needed is changing the UPPERCASE_NAMES in celery_instance.py to the lowercase_names in the celery 4.x conf docs?

Actions
Copy link
 #9

Updated by bizhang over 6 years ago

jwelborn yep! Since celery will complain if there's a mix of old and new config settings names, you can be sure that everything works if it doesn't complain after you restart the pulp services by running prestart and pstatus on a vagrant environment.

Actions
Copy link
 #10

Updated by jwelborn over 6 years ago

  • Assignee set to jwelborn

PR incoming!

Actions
Copy link
 #11

Updated by bizhang over 6 years ago

  • Status changed from NEW to POST

Added by werwty over 6 years ago

Revision 83aa043a | View on GitHub

Merge pull request #3130 from JayWelborn/update-celery-conf-names

updated celery conf names

Actions
Copy link
 #12

Updated by bizhang over 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #13

Updated by daviddavis about 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #14

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #15

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF