Refactor #2963
closed
Use the new lower case celery config settings
0%
Description
Celery 4 introduces new config settings with better naming. More info:
http://docs.celeryproject.org/en/latest/userguide/configuration.html#new-lowercase-settings
Updated by ttereshc over 7 years ago
- Tracker changed from Issue to Refactor
- % Done set to 0
Updated by jwelborn over 7 years ago
Hi, I found this issue browsing looking for easy fixes.
Is this just changing the names here to the lowercase celery 4 names?
If so, can I help?
Updated by bizhang over 7 years ago
jwelborn help would be great!
The names are the celery setting configuration names found here: https://github.com/pulp/pulp/blob/b7d07fff4685e6914453f0bdc8361b5c99d3fd5d/platform/pulpcore/tasking/celery_instance.py#L20
Updated by jwelborn over 7 years ago
Since this is a pulp 3 fix, should I pull against 3.0-dev?
Updated by jwelborn over 7 years ago
Just to make sure I'm not oversimplifying this:
All that's needed is changing the UPPERCASE_NAMES in celery_instance.py to the lowercase_names in the celery 4.x conf docs?
Updated by bizhang over 7 years ago
jwelborn yep! Since celery will complain if there's a mix of old and new config settings names, you can be sure that everything works if it doesn't complain after you restart the pulp services by running prestart and pstatus on a vagrant environment.
Updated by bizhang over 7 years ago
- Status changed from NEW to POST
Added by werwty over 7 years ago
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Merge pull request #3130 from JayWelborn/update-celery-conf-names
updated celery conf names