Task #2914: Add support for Pulp to handle X-SEND and X-Accel-Redirect response headers - Pulp

Send by e-mail

Task #2914

Task #2868: Platform support for publishing.

Add support for Pulp to handle X-SEND and X-Accel-Redirect response headers

Added by jortel@redhat.com over 2 years ago. Updated 6 months ago.

Status:

MODIFIED

Priority:

Normal

Assignee:

jortel@redhat.com

Category:

Sprint/Milestone:

3.0

Start date:

Due date:

% Done:

100%

Platform Release:

Blocks Release:

Backwards Incompatible:

Groomed:

Yes

Sprint Candidate:

Yes

Tags:

QA Contact:

Complexity:

Smash Test:

Verified:

Verification Required:

Sprint:

Sprint 28

Description

The ContentView needs to be updated to detect if XSEND can/should be used to stream bits. The pulp2 code⁰ to add the X-SENDFILE header should also be ported.

It should be noted that nginx does not use the X-SENDFILE header, but rather the X-Accel-Redirect header.

It would be good to support either of these servers. Prehaps a default property named webserver in settings.py and a user config in server.yaml that defaults to None, and can be set to None, apache, or nginx

[0] https://github.com/pulp/pulp/blob/96db0a2eefe12683cd439d9a00e57a4da0876dbc/server/pulp/server/content/web/views.py#L74

Hide closed

Checklist

Update ContentView
Add config opinion to server.yaml and settings.py
update the config options docs
If the webserver setting is 'apache' have file responses respond with the X-SEND response header
If the webserver setting is 'nginx' have file responses respond with the X-Accel-Redirect response header

Associated revisions

Revision ec922115 View on GitHub
Added by jortel@redhat.com almost 2 years ago

Support x-send and nginx headers.
closes #2914

Revision ec922115 View on GitHub
Added by jortel@redhat.com almost 2 years ago

Support x-send and nginx headers.
closes #2914

Revision ec922115 View on GitHub
Added by jortel@redhat.com almost 2 years ago

Support x-send and nginx headers.
closes #2914

History

#1 Updated by jortel@redhat.com over 2 years ago

Description updated (diff)

#2 Updated by bmbouter over 2 years ago

Subject changed from Add support for Apache integration and X-SEND files in Content WSGI application. to Add support for Apache integration and X-SEND files

I think for the foreseable future we will only have 1 WSGI application serving all content requests include API and content requests. I think the adding of XSend support and Apache can continue with that 1 WSGI application and if we want to break it out we could do that as separate work.

#3 Updated by bizhang over 2 years ago

Subject changed from Add support for Apache integration and X-SEND files to Add support for Pulp to handle X-SEND files
Description updated (diff)

After discussion with @jortel I'm rewriting this to be a xsend task and am creating a new task to create an ansible apache role

#4 Updated by bmbouter almost 2 years ago

Subject changed from Add support for Pulp to handle X-SEND files to Add support for Pulp to handle X-SEND and X-Accel-Redirect response headers
Description updated (diff)

Retitling, added checklist items, and groomed. I also updated the description to specify the name webserver.